You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request should establish the initial format and tools for the replication of block extraction from 3D volumes and the post-processing of SGNs.
I split the functionality of the block extraction formerly entirely localized within scripts/extract_block.py into the function being localized in flamingo_tools/extract_block.py, so that it is also accessible from other modules. Should I call such functions [...]_utils.py or what would be a good practice?
I split the functionality of the block extraction formerly entirely localized within scripts/extract_block.py into the function being localized in flamingo_tools/extract_block.py, so that it is also accessible from other modules. Should I call such functions [...]_utils.py or what would be a good practice?
Yes, I think calling it something with util at the end make sense, maybe block_extraction_util.py? That sounds more natural.
Besides this, the PR looks good to merge from my end. So go ahead and merge it once it's ready from your end.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request should establish the initial format and tools for the replication of block extraction from 3D volumes and the post-processing of SGNs.
WIP