added liblifthttp 4.4.2 recipe#27532
Conversation
e92183f to
61c945e
Compare
61c945e to
2a9a8bc
Compare
uilianries
left a comment
There was a problem hiding this comment.
@laci-aura Hello, and thank you for your PR! Sorry for the delay in reviewing this PR.
As part of this review, I sent some suggestions directly to the liblifhttp project on the PRs:
Please, take a look at my review as well. Regards!
There was a problem hiding this comment.
@laci-aura Hello! Thank you for continuing this PR after that review. It's getting better; now it's just a matter of details to make it work.
The dependency libuv may differ its CMake according to its version and configuration (static/shared). The Mac build failed due to that inconsistency. My suggestion is to keep the libuv's CMake target name aligned, so we avoid that kind of error.
|
@uilianries Hello, thank you for the dream reviews where my part was just to commit suggested changes |
uilianries
left a comment
There was a problem hiding this comment.
@laci-aura One more step: Now Windows build fails because when generating shared library configuration, the project does not export those library symbols to a .lib file. This is not a blocker, so let's only skip this configuration for now.
d5070f5 to
aab1cee
Compare
There was a problem hiding this comment.
LGTM
- There is no cmake intall support. Added later: jbaldwin/liblifthttp#177
- Windows shared is not supported yet: jbaldwin/liblifthttp#179
- Project requires libcurl and libuv: jbaldwin/liblifthttp#178
- Requires C++17: https://github.com/jbaldwin/liblifthttp/blob/v4.4.2/CMakeLists.txt#L63
- License Apache-2.0: https://github.com/jbaldwin/liblifthttp/blob/v4.4.2/LICENSE
- CMAKE_PROJECT_lifthttp_INCLUDE is required because the project does not use find_package.
| tc.variables["CMAKE_PROJECT_lifthttp_INCLUDE"] = "conan_deps.cmake" | ||
| tc.variables["LIFT_BUILD_EXAMPLES"] = False | ||
| tc.variables["LIFT_BUILD_TESTS"] = False | ||
| tc.variables["LIFT_USER_LINK_LIBRARIES"] = "CURL::libcurl;libuv::uv" | ||
| if self.settings.os in ["Linux", "FreeBSD"]: | ||
| tc.variables["LIFT_USER_LINK_LIBRARIES"] += ";pthread;dl" |
There was a problem hiding this comment.
| tc.variables["CMAKE_PROJECT_lifthttp_INCLUDE"] = "conan_deps.cmake" | |
| tc.variables["LIFT_BUILD_EXAMPLES"] = False | |
| tc.variables["LIFT_BUILD_TESTS"] = False | |
| tc.variables["LIFT_USER_LINK_LIBRARIES"] = "CURL::libcurl;libuv::uv" | |
| if self.settings.os in ["Linux", "FreeBSD"]: | |
| tc.variables["LIFT_USER_LINK_LIBRARIES"] += ";pthread;dl" | |
| tc.cache_variables["CMAKE_PROJECT_lifthttp_INCLUDE"] = "conan_deps.cmake" | |
| tc.cache_variables["LIFT_BUILD_EXAMPLES"] = False | |
| tc.cache_variables["LIFT_BUILD_TESTS"] = False | |
| tc.cache_variables["LIFT_USER_LINK_LIBRARIES"] = "CURL::libcurl;libuv::uv" | |
| if self.settings.os in ["Linux", "FreeBSD"]: | |
| tc.cache_variables["LIFT_USER_LINK_LIBRARIES"] += ";pthread;dl" |
There was a problem hiding this comment.
these need to be cache_variables rather than toolchain variables
|
Merging with an oustanding comment as it's not critical if it's not causing problems, but new recipes should use |
* added lifthttp recipe * added support for shared build * removed deprecated stdc++fs dependency * added version 4.4.1 * added version 4.4.2 * Revert "added version 4.4.1" This reverts commit 48146fa. * removed version 4.4.0 * applied PR review suggestions * set uv cmake target name to libuv::uv * added windows shared build error * fixed is_msvc import * added layout method * changed name to liblifthttp
* added lifthttp recipe * added support for shared build * removed deprecated stdc++fs dependency * added version 4.4.1 * added version 4.4.2 * Revert "added version 4.4.1" This reverts commit 48146fa. * removed version 4.4.0 * applied PR review suggestions * set uv cmake target name to libuv::uv * added windows shared build error * fixed is_msvc import * added layout method * changed name to liblifthttp
* added lifthttp recipe * added support for shared build * removed deprecated stdc++fs dependency * added version 4.4.1 * added version 4.4.2 * Revert "added version 4.4.1" This reverts commit 48146fa. * removed version 4.4.0 * applied PR review suggestions * set uv cmake target name to libuv::uv * added windows shared build error * fixed is_msvc import * added layout method * changed name to liblifthttp
Summary
Initial recipe: liblifthttp/4.4.2
Details
liblifthttp - Safe Easy to use C++17 HTTP client library
https://github.com/jbaldwin/liblifthttp