Skip to content

added liblifthttp 4.4.2 recipe#27532

Merged
jcar87 merged 13 commits intoconan-io:masterfrom
figleafteam:laci-aura/add-liblifthttp-recipe
Dec 23, 2025
Merged

added liblifthttp 4.4.2 recipe#27532
jcar87 merged 13 commits intoconan-io:masterfrom
figleafteam:laci-aura/add-liblifthttp-recipe

Conversation

@laci-aura
Copy link
Contributor

@laci-aura laci-aura commented May 26, 2025

Summary

Initial recipe: liblifthttp/4.4.2

Details

liblifthttp - Safe Easy to use C++17 HTTP client library
https://github.com/jbaldwin/liblifthttp


@laci-aura laci-aura requested a review from jcar87 September 16, 2025 18:10
@laci-aura laci-aura force-pushed the laci-aura/add-liblifthttp-recipe branch from e92183f to 61c945e Compare September 16, 2025 18:12
@laci-aura laci-aura changed the title added liblifthttp 4.4.0 recipe added liblifthttp 4.4.2 recipe Sep 16, 2025
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@laci-aura Hello, and thank you for your PR! Sorry for the delay in reviewing this PR.

As part of this review, I sent some suggestions directly to the liblifhttp project on the PRs:

Please, take a look at my review as well. Regards!

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@laci-aura Hello! Thank you for continuing this PR after that review. It's getting better; now it's just a matter of details to make it work.

The dependency libuv may differ its CMake according to its version and configuration (static/shared). The Mac build failed due to that inconsistency. My suggestion is to keep the libuv's CMake target name aligned, so we avoid that kind of error.

@laci-aura
Copy link
Contributor Author

@uilianries Hello, thank you for the dream reviews where my part was just to commit suggested changes

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@laci-aura One more step: Now Windows build fails because when generating shared library configuration, the project does not export those library symbols to a .lib file. This is not a blocker, so let's only skip this configuration for now.

@laci-aura laci-aura requested a review from uilianries December 23, 2025 13:58
@laci-aura laci-aura force-pushed the laci-aura/add-liblifthttp-recipe branch from d5070f5 to aab1cee Compare December 23, 2025 14:23
@laci-aura laci-aura requested a review from uilianries December 23, 2025 14:25
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +58 to +63
tc.variables["CMAKE_PROJECT_lifthttp_INCLUDE"] = "conan_deps.cmake"
tc.variables["LIFT_BUILD_EXAMPLES"] = False
tc.variables["LIFT_BUILD_TESTS"] = False
tc.variables["LIFT_USER_LINK_LIBRARIES"] = "CURL::libcurl;libuv::uv"
if self.settings.os in ["Linux", "FreeBSD"]:
tc.variables["LIFT_USER_LINK_LIBRARIES"] += ";pthread;dl"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
tc.variables["CMAKE_PROJECT_lifthttp_INCLUDE"] = "conan_deps.cmake"
tc.variables["LIFT_BUILD_EXAMPLES"] = False
tc.variables["LIFT_BUILD_TESTS"] = False
tc.variables["LIFT_USER_LINK_LIBRARIES"] = "CURL::libcurl;libuv::uv"
if self.settings.os in ["Linux", "FreeBSD"]:
tc.variables["LIFT_USER_LINK_LIBRARIES"] += ";pthread;dl"
tc.cache_variables["CMAKE_PROJECT_lifthttp_INCLUDE"] = "conan_deps.cmake"
tc.cache_variables["LIFT_BUILD_EXAMPLES"] = False
tc.cache_variables["LIFT_BUILD_TESTS"] = False
tc.cache_variables["LIFT_USER_LINK_LIBRARIES"] = "CURL::libcurl;libuv::uv"
if self.settings.os in ["Linux", "FreeBSD"]:
tc.cache_variables["LIFT_USER_LINK_LIBRARIES"] += ";pthread;dl"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these need to be cache_variables rather than toolchain variables

@jcar87
Copy link
Contributor

jcar87 commented Dec 23, 2025

Merging with an oustanding comment as it's not critical if it's not causing problems, but new recipes should use tc.cache_variables for CMakeToolchain

@jcar87 jcar87 merged commit 6f4f4b6 into conan-io:master Dec 23, 2025
9 checks passed
vilasfe pushed a commit to vilasfe/conan-center-index that referenced this pull request Dec 30, 2025
* added lifthttp recipe

* added support for shared build

* removed deprecated stdc++fs dependency

* added version 4.4.1

* added version 4.4.2

* Revert "added version 4.4.1"

This reverts commit 48146fa.

* removed version 4.4.0

* applied PR review suggestions

* set uv cmake target name to libuv::uv

* added windows shared build error

* fixed is_msvc import

* added layout method

* changed name to liblifthttp
interfector18 pushed a commit to interfector18/conan-center-index that referenced this pull request Jan 11, 2026
* added lifthttp recipe

* added support for shared build

* removed deprecated stdc++fs dependency

* added version 4.4.1

* added version 4.4.2

* Revert "added version 4.4.1"

This reverts commit 48146fa.

* removed version 4.4.0

* applied PR review suggestions

* set uv cmake target name to libuv::uv

* added windows shared build error

* fixed is_msvc import

* added layout method

* changed name to liblifthttp
praetorian20 pushed a commit to praetorian20/conan-center-index that referenced this pull request Jan 15, 2026
* added lifthttp recipe

* added support for shared build

* removed deprecated stdc++fs dependency

* added version 4.4.1

* added version 4.4.2

* Revert "added version 4.4.1"

This reverts commit 48146fa.

* removed version 4.4.0

* applied PR review suggestions

* set uv cmake target name to libuv::uv

* added windows shared build error

* fixed is_msvc import

* added layout method

* changed name to liblifthttp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants