Skip to content

Conversation

@thorque
Copy link
Collaborator

@thorque thorque commented Jul 8, 2025

No description provided.

Copilot AI review requested due to automatic review settings July 8, 2025 20:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors documentation templates and the main README to remove outdated trigger sections, updates build and development commands, restructures the OpenAPI generator script by moving description into a constructor, and adjusts package configuration including a scoped package name, version bump, and publish settings.

  • Clean up and simplify README and README.template.md, updating example numbering and build commands.
  • Refactor openapi-generator.js to initialize description in a constructor and replace the NodeConnectionType import.
  • Update package.json with a scoped name, new version, publishConfig, and adjust which node files are packaged.

Reviewed Changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
templates/README.template.md Removed deprecated trigger docs and updated example numbering
scripts/openapi-generator.js Moved description into constructor, commented out n8n-workflow import
package.json Scoped package name, bumped version, publishConfig, trimmed files list and nodes
nodes/ConfluenceCloud/ConfluenceCloudTrigger.node.json Changed node reference and added version/codex metadata
nodes/ConfluenceCloud/ConfluenceCloud.node.json Changed node reference and added version/codex metadata
index.js Removed default export (no longer used)
README.md Mirrored template cleanup and updated commands
Comments suppressed due to low confidence (2)

nodes/ConfluenceCloud/ConfluenceCloudTrigger.node.json:2

  • [nitpick] Update the node identifier to use your scoped package name (@conciso/n8n-nodes-confluence-cloud) instead of n8n-nodes-base to ensure consistency with the published package.
	"node": "n8n-nodes-base.ConfluenceCloudTrigger",

package.json:52

  • The trigger node (ConfluenceCloudTrigger.node.js) was removed from the n8n.nodes list, but its JSON manifest still exists. If you intend to publish the trigger, add it back here; otherwise remove its manifest to avoid packaging inconsistencies.
      "dist/nodes/ConfluenceCloud/ConfluenceCloud.node.js"

@thorque thorque merged commit 2b04ff4 into development Jul 8, 2025
6 checks passed
@thorque thorque deleted the bug/CCE-2765-confluence-node-erzeugt-einen-fehler-bei-der-insta branch July 8, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants