Refactor README and templates, update node configurations, and enhance TypeScript settings#5
Merged
thorque merged 3 commits intodevelopmentfrom Jul 8, 2025
Conversation
…e TypeScript settings
There was a problem hiding this comment.
Pull Request Overview
This PR refactors documentation templates and the main README to remove outdated trigger sections, updates build and development commands, restructures the OpenAPI generator script by moving description into a constructor, and adjusts package configuration including a scoped package name, version bump, and publish settings.
- Clean up and simplify README and
README.template.md, updating example numbering and build commands. - Refactor
openapi-generator.jsto initializedescriptionin a constructor and replace theNodeConnectionTypeimport. - Update
package.jsonwith a scoped name, new version, publishConfig, and adjust which node files are packaged.
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| templates/README.template.md | Removed deprecated trigger docs and updated example numbering |
| scripts/openapi-generator.js | Moved description into constructor, commented out n8n-workflow import |
| package.json | Scoped package name, bumped version, publishConfig, trimmed files list and nodes |
| nodes/ConfluenceCloud/ConfluenceCloudTrigger.node.json | Changed node reference and added version/codex metadata |
| nodes/ConfluenceCloud/ConfluenceCloud.node.json | Changed node reference and added version/codex metadata |
| index.js | Removed default export (no longer used) |
| README.md | Mirrored template cleanup and updated commands |
Comments suppressed due to low confidence (2)
nodes/ConfluenceCloud/ConfluenceCloudTrigger.node.json:2
- [nitpick] Update the
nodeidentifier to use your scoped package name (@conciso/n8n-nodes-confluence-cloud) instead ofn8n-nodes-baseto ensure consistency with the published package.
"node": "n8n-nodes-base.ConfluenceCloudTrigger",
package.json:52
- The trigger node (
ConfluenceCloudTrigger.node.js) was removed from then8n.nodeslist, but its JSON manifest still exists. If you intend to publish the trigger, add it back here; otherwise remove its manifest to avoid packaging inconsistencies.
"dist/nodes/ConfluenceCloud/ConfluenceCloud.node.js"
…fluenceCloudTrigger node files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.