Allow adding arbitrary buildkit config #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Params like `REGISTRY_MIRRORS` don't really scale well to cover a complex schema like buildkit's toml configuration. Plus, they can become out-of-date. A param whose content is written verbatim to the config file allows defining everything the configuration has to offer, now and in the future. It also avoids having to add new params one by one as users request the ability to configure individual values. Closes: concourse#120 Signed-off-by: Lucas Schwiderski <[email protected]>
sclu1034
force-pushed
the
feat/extra-buildkit-config
branch
from
6ea6ac8 to
9a50d4e
Compare
taylorsilva
requested changes
Apr 15, 2025
Member
taylorsilva
left a comment
taylorsilva
left a comment
There was a problem hiding this comment.
I'm not completely against the escape-hatch here. I do worry about the resulting configuration being valid TOML though, especially since we're blindly appending this user input to the config file.
I guess what I'm looking for here is a test or two. If you're still interested in this PR could you please add tests. If not then feel free to close the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Params like
REGISTRY_MIRRORSdon't really scale well to cover a complex schema like buildkit's toml configuration. Plus, they can become out-of-date.A param whose content is written verbatim to the config file allows defining everything the configuration has to offer, now and in the future. It also avoids having to add new params one by one as users request the ability to configure individual values.
Closes: #120