-
-
Notifications
You must be signed in to change notification settings - Fork 452
Add requests-ntlm output to requests_ntlm feedstock #1824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8945a2a to
1ef379c
Compare
|
I am still seeing failure in conda-forge/requests_ntlm-feedstock#7 where I try to add the new output package. @beckermr when should this take effect? |
|
It should take effect very quickly; if it still hasn't worked after 8h, then likely something went wrong somewhere... At least, I double-checked the spelling in this PR and can find no mistakes. From the PR your referenced, this is how the validation still looks like |
|
I found the bug but won't be able to fix and cleanup until tomorrow. |
|
Is there somewhere I can watch to know when the |
Manual fix until conda-forge/admin-requests#1824 is sorted out
|
Hi Sorry. The issue is that this yaml bit was misinterpreted by the code. It interpreted the string @isuruf changed how this is formatted recently and somehow this edge case isn't working. |
Ah, good find! Well yeah, the new format requires a list. We should error if we find a bare string, instead of listifying it (or alternatively, error if we find that the list is comprised of single characters) |
|
Ok this is fixed and the output should be present momentarily. We need to go in and cleanup the outputs from the buggy code. |
Checklist:
ping @conda-forge/requests_ntlm
This is following up the suggestion made in regro/cf-scripts#5250 (comment) and discussed in conda-forge/requests_ntlm-feedstock#6