Skip to content

Conversation

@wshanks
Copy link
Contributor

@wshanks wshanks commented Jan 7, 2026

Checklist:

  • I want to add a package output to a feedstock:
    • Pinged the relevant feedstock team(s)
    • Added a small description of why the output is being added.

ping @conda-forge/requests_ntlm

This is following up the suggestion made in regro/cf-scripts#5250 (comment) and discussed in conda-forge/requests_ntlm-feedstock#6

@wshanks wshanks requested a review from a team as a code owner January 7, 2026 21:47
@wshanks wshanks force-pushed the requests_ntlm-outputs branch from 8945a2a to 1ef379c Compare January 7, 2026 21:54
@beckermr beckermr merged commit a1a76b0 into conda-forge:main Jan 7, 2026
1 check passed
@wshanks wshanks deleted the requests_ntlm-outputs branch January 8, 2026 05:05
@wshanks
Copy link
Contributor Author

wshanks commented Jan 8, 2026

I am still seeing failure in conda-forge/requests_ntlm-feedstock#7 where I try to add the new output package. @beckermr when should this take effect?

@h-vetinari
Copy link
Member

It should take effect very quickly; if it still hasn't worked after 8h, then likely something went wrong somewhere... At least, I double-checked the spelling in this PR and can find no mistakes. From the PR your referenced, this is how the validation still looks like

validation results:
{
  "noarch/requests-ntlm-1.3.0-h795da4c_2.conda": false,
  "noarch/requests_ntlm-1.3.0-pyhcf101f3_2.conda": true
}

@beckermr
Copy link
Member

beckermr commented Jan 8, 2026

I found the bug but won't be able to fix and cleanup until tomorrow.

@wshanks
Copy link
Contributor Author

wshanks commented Jan 9, 2026

Is there somewhere I can watch to know when the requests-ntlm output has been added?

wshanks added a commit to regro-cf-autotick-bot/qiskit-ibm-runtime-feedstock that referenced this pull request Jan 9, 2026
Manual fix until conda-forge/admin-requests#1824 is sorted out
@beckermr
Copy link
Member

beckermr commented Jan 9, 2026

Hi Sorry. The issue is that this yaml bit

action: add_feedstock_output
feedstock_to_output_mapping:
  requests_ntlm: requests-ntlm

was misinterpreted by the code. It interpreted the string requests-ntlm as a list and made outputs for each character. 🤦

@isuruf changed how this is formatted recently and somehow this edge case isn't working.

@h-vetinari
Copy link
Member

It interpreted the string requests-ntlm as a list

Ah, good find! Well yeah, the new format requires a list. We should error if we find a bare string, instead of listifying it (or alternatively, error if we find that the list is comprised of single characters)

@beckermr
Copy link
Member

beckermr commented Jan 9, 2026

Ok this is fixed and the output should be present momentarily. We need to go in and cleanup the outputs from the buggy code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants