Skip to content

Conversation

@davidbrochart
Copy link
Member

Guidelines for marking packages as broken:

  • We prefer to patch the repo data (see here)
    instead of marking packages as broken. This alternative workflow makes environments more reproducible.
  • Packages with requirements/metadata that are too strict but otherwise work are
    not technically broken and should not be marked as such.
  • Packages with missing metadata can be marked as broken on a temporary basis
    but should be patched in the repo data and be marked unbroken later.
  • In some cases where the number of users of a package is small or it is used by
    the maintainers only, we can allow packages to be marked broken more liberally.
  • We (conda-forge/core) try to make a decision on these requests within 24 hours.

Checklist:

  • Make sure your package is in the right spot (broken/* for adding the
    broken label, not_broken/* for removing the broken label, or token_reset/*
    for token resets)
  • Added a description of the problem with the package in the PR description.
  • Added links to any relevant issues/PRs in the PR description.
  • Pinged the team for the package for their input.

The block kwarg was removed from get_msg(), which is breaking the API. See e.g. ipython/ipykernel#633.

cc @SylvainCorlay

@davidbrochart davidbrochart requested a review from a team as a code owner April 12, 2021 16:56
@isuruf
Copy link
Member

isuruf commented Apr 12, 2021

Is it not supposed to break the API?

@SylvainCorlay
Copy link
Member

Is it not supposed to break the API?

This should have been a major release.

@SylvainCorlay
Copy link
Member

Is it not supposed to break the API?

This should have been a major release.

(if the API has to be broken)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants