-
-
Notifications
You must be signed in to change notification settings - Fork 64
[8.0.x] Feature sync with main & upstream #860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge-admin, please rerender |
…nda-forge-pinning 2022.09.13.19.09.01
|
So I don't fully get the relationship between gandiva & jemalloc (there should be none?), but in any case, this works if I backport apache/arrow@2c87e81, or presumably I could kick out 6f78775 Any preferences which approach I should take? If it were up to me, I'd backport the jemalloc version bump (& gandiva enablement) back until 6.0.x. |
fea11bb to
8bfdf7a
Compare
|
I'd be more in favor of backporting apache/arrow@2c87e81 |
There are now passing builds (with the same approach) for 7.0.x and 6.0.x as well. Key part being the gandiva enablement on osx-arm back to 6.0 |
|
@conda-forge/arrow-cpp If someone has concerns / objections to backporting gandiva-on-osx-arm & a jemalloc bump (also mostly for osx-arm) back to all supported versions in conda-forge (until 6.0.x), please let me know. In case there are no further comments, I'll merge this & #863 & #864 on the weekend. PS. These PRs also contain some further clean-ups & make the branches consistent (as much as possible/reasonable) with main resp. apache/arrow#14102 |
kkraus14
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'm technically not a maintainer on this recipe 😆
Combination of #853 & #848 for 8.0.x
I double-checked when the features (enabled in a807519) landed:
However, despite
ARROW_GCSseemingly landing in 9.0, it was enabled here in #677 during the 7.0 cycle.CC @xhochy @pitrou @kkraus14