Skip to content

Conversation

@h-vetinari
Copy link
Member

Combination of #853 & #848 for 8.0.x

I double-checked when the features (enabled in a807519) landed:

However, despite ARROW_GCS seemingly landing in 9.0, it was enabled here in #677 during the 7.0 cycle.

CC @xhochy @pitrou @kkraus14

@conda-forge-linter
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari
Copy link
Member Author

@conda-forge-admin, please rerender

@h-vetinari h-vetinari changed the title [8.0.x] Feature sync with main/upstream [8.0.x] Feature sync with main & upstream Sep 13, 2022
conda-forge-webservices[bot] and others added 2 commits September 13, 2022 20:16
@h-vetinari
Copy link
Member Author

So I don't fully get the relationship between gandiva & jemalloc (there should be none?), but in any case, this works if I backport apache/arrow@2c87e81, or presumably I could kick out 6f78775

Any preferences which approach I should take? If it were up to me, I'd backport the jemalloc version bump (& gandiva enablement) back until 6.0.x.

WDYT @xhochy @pitrou @kkraus14?

@h-vetinari h-vetinari force-pushed the refresh_8.0 branch 2 times, most recently from fea11bb to 8bfdf7a Compare September 13, 2022 22:04
@h-vetinari h-vetinari marked this pull request as ready for review September 13, 2022 22:05
@kkraus14
Copy link
Contributor

I'd be more in favor of backporting apache/arrow@2c87e81

@h-vetinari
Copy link
Member Author

I'd be more in favor of backporting apache/arrow@2c87e81

There are now passing builds (with the same approach) for 7.0.x and 6.0.x as well. Key part being the gandiva enablement on osx-arm back to 6.0

@h-vetinari
Copy link
Member Author

@conda-forge/arrow-cpp

If someone has concerns / objections to backporting gandiva-on-osx-arm & a jemalloc bump (also mostly for osx-arm) back to all supported versions in conda-forge (until 6.0.x), please let me know.

In case there are no further comments, I'll merge this & #863 & #864 on the weekend.

PS. These PRs also contain some further clean-ups & make the branches consistent (as much as possible/reasonable) with main resp. apache/arrow#14102

Copy link
Contributor

@kkraus14 kkraus14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm technically not a maintainer on this recipe 😆

@h-vetinari h-vetinari merged commit ea0beb2 into conda-forge:8.0.x Sep 17, 2022
@h-vetinari h-vetinari deleted the refresh_8.0 branch September 17, 2022 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants