-
-
Notifications
You must be signed in to change notification settings - Fork 579
Update pins for Azure Storage January 2026 release #8132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/20962260311. Examine the logs at this URL for more detail. |
jjerphan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @jdblischak.
LGTM (I did not see #7856 initally).
I left comments and approval on feedstocks' PRs, I let you proceed with merging them first.
This time I was going to try and combine the version bumps and the migration PRs |
|
Hum, mustn't we first have merged all the PRs of feedstocks which have been linked? :) |
Nope, because of |
|
Nevermind, I misunderstood #8132 (comment) (I thought it meant waiting for all feedstocks to have their version bumped before starting the migration, and I did not know that starting the migration before was possible). |
|
As I see it, there are two main strategies for pushing through the updates and migrations for these azure feedstocks:
|
So far it is off to a bad start. The migration is blocked because the bot can't bot can't solve the environment: At minimum I'll need to merge the azure-storage-common-cpp 12.12.0 update PR first. Then we'll see if the migration can continue. |
|
Yeah, the migrator needs at least one library to have been successfully built to solve a child feedstock. |
|
While I like that my current strategy avoids uploading unnecessary conda binaries, everything else about it is decidedly worse. Combining the version bump and migration PRs requires more manual intervention, we still have to merge the first package in the dependency network (in this case it was storage-common but would typically be core), and individual PRs to update the pins are still opened (and thus will need to be manually closed). So going forward, as long as the CI passes, I think we should follow the strategy of #7856: merge all the version bump PRs, create a combined migration PR, list all the independent version bump PRs to be auto-closed. |
Note that for this migration, the datalake 12.14.0 version bump PR failed without its updated dependencies, so it would have had to have waited for the combined migration regardless (conda-forge/azure-storage-files-datalake-cpp-feedstock#24 (comment), conda-forge/azure-storage-files-datalake-cpp-feedstock#25) |
|
@jdblischak, I think the synthesis here is that the optimum is somewhere in the middle, and may not be the same from migration to migration. Personally, I think it'd be viable to merge the version updates that pass, and leave the ones open that don't, before starting the migration (for example). |
|
Quick status update on the azure storage migration:
|
|
Status updates:
Thanks @h-vetinari and @jjerphan! |
xref: Azure/azure-sdk-for-cpp#6895, conda-forge/azure-storage-common-cpp-feedstock#28, conda-forge/azure-storage-blobs-cpp-feedstock#25, conda-forge/azure-storage-files-shares-cpp-feedstock#23, conda-forge/azure-storage-files-datalake-cpp-feedstock#24, conda-forge/azure-storage-queues-cpp-feedstock#17, #7856, #6471
cc: @jjerphan, @h-vetinari, @teo-tsirpanis, @conda-forge/azure-storage-common-cpp