Skip to content

enable patched tests#30

Open
timsnyder wants to merge 4 commits intoconda-forge:mainfrom
timsnyder:try_patched_tests_in_ci
Open

enable patched tests#30
timsnyder wants to merge 4 commits intoconda-forge:mainfrom
timsnyder:try_patched_tests_in_ci

Conversation

@timsnyder
Copy link

test failures in 0.186 were due to a few things:

  • need cap_sys_ptrace to run some tests. I patched these to skip
    and if we're unable to add cap_sys_ptrace to the docker cmdline
    I'll propose it upstream
  • build everything with -g because some of the dwarf stuff is tested
    by introspecting the elfutils. strip stuff at install time
  • test-nlist is really fragile and draconian in how it treats CFLAGS
    just patch it out of the automake file (that's why I need to
    autoreconf now)
  • many of the tests won't compile cleanly with NDEBUG because there
    are many assertions that we probably want during testing. The
    cost of assertions in the utilites is low enough that we should just
    leave them in them. Also given the esoteric nature of this package,
    leaving the assertions in is probably a good idea.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

test failures in 0.186 were due to a few things:
* need cap_sys_ptrace to run some tests.  I patched these to skip
  and if we're unable to add cap_sys_ptrace to the docker cmdline
  I'll propose it upstream
* build everything with -g because some of the dwarf stuff is tested
  by introspecting the elfutils.  strip stuff at install time
* test-nlist is really fragile and draconian in how it treats CFLAGS
  just patch it out of the automake file (that's why I need to
  autoreconf now)
* many of the tests won't compile cleanly with NDEBUG because there
  are many assertions that we probably want during testing.  The
  cost of assertions in the utilites is low enough that we should just
  leave them in them.  Also given the esoteric nature of this package,
  leaving the assertions in is probably a good idea.
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@timsnyder
Copy link
Author

@conda-forge-admin , please rerender.

@timsnyder
Copy link
Author

Failures on arm and ppc look legit. Going to debug them in local builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants