Open
Conversation
test failures in 0.186 were due to a few things: * need cap_sys_ptrace to run some tests. I patched these to skip and if we're unable to add cap_sys_ptrace to the docker cmdline I'll propose it upstream * build everything with -g because some of the dwarf stuff is tested by introspecting the elfutils. strip stuff at install time * test-nlist is really fragile and draconian in how it treats CFLAGS just patch it out of the automake file (that's why I need to autoreconf now) * many of the tests won't compile cleanly with NDEBUG because there are many assertions that we probably want during testing. The cost of assertions in the utilites is low enough that we should just leave them in them. Also given the esoteric nature of this package, leaving the assertions in is probably a good idea.
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Author
|
@conda-forge-admin , please rerender. |
…nda-forge-pinning 2022.04.02.04.11.01
Author
|
Failures on arm and ppc look legit. Going to debug them in local builds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test failures in 0.186 were due to a few things:
and if we're unable to add cap_sys_ptrace to the docker cmdline
I'll propose it upstream
by introspecting the elfutils. strip stuff at install time
just patch it out of the automake file (that's why I need to
autoreconf now)
are many assertions that we probably want during testing. The
cost of assertions in the utilites is low enough that we should just
leave them in them. Also given the esoteric nature of this package,
leaving the assertions in is probably a good idea.
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)