Skip to content

Conversation

@h-vetinari
Copy link
Member

Rehash of #108 (with less thrashing), continuation of #107

Closes #107

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari
Copy link
Member Author

@coryan PTAL
This is a slimmed down version of #107 (also on C++17). I'll try another PR just for the shared builds, but just for the purpose of progressing on abseil, we should be good now. :)

@coryan coryan merged commit ae26eb9 into conda-forge:main Sep 6, 2022
@coryan
Copy link
Contributor

coryan commented Sep 6, 2022

@h-vetinari thanks and welcome.

@h-vetinari h-vetinari deleted the abseil_minimal branch September 6, 2022 13:05
@h-vetinari
Copy link
Member Author

@h-vetinari thanks and welcome.

Thank you too for the helpful inputs & quick reviews! :)

PS. I usually try to have pretty clean commit histories, and I think it's better in such cases not to squash. For example, we'll have to revert (morally) 1eb18c8 at some point, and generally having a richer history helps navigating (IMO) how the recipe evolved (in particular, mixing bot commits with "recipe-only" commits makes this harder).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants