Rebuild for libabseil 20250127, libgrpc 1.71 & libprotobuf 5.29.3 #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nda-forge-pinning 2025.03.13.20.26.56
regro-cf-autotick-bot
requested review from
davidbrochart,
dbolduc,
h-vetinari and
xhochy
as code owners
Contributor
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/14568022151. Examine the logs at this URL for more detail. |
Member
|
@coryan, is google-cloud-cpp compatible with protobuf v29.3 & grpc 1.71 already? which is a bit surprising, because we just generated the respective files further up with - what should be - a consistent set of protoc/grpc: Of course, it's not impossible that this is due to the extensive hackery that was necessary to get the current round of version increments to work, but it's a bit curious nevertheless, because all the other feedstocks so far were fine, and also, exporting PS. Huh, I had missed 80ca7d3 - hope you don't mind the ping. Otherwise the same question goes to @dbolduc 😅 |
Contributor
|
It looks like we only build against protobuf 29.3 upstream. We have not adopted a gRPC past 1.69.0. I have not been following why. googleapis/google-cloud-cpp#14922 Aside: I am no longer on the google-cloud-cpp project either. I will soon send PRs to remove myself as a maintainer here. cc: @scotthart who knows more about the state of google-cloud-cpp and its dependencies than I do |
Contributor
Don't mind at all. I speculate that this:
Has something to do with a recently fixed bug in gRPC: grpc/grpc#33501 But I say this only because of a loose pattern match: |
…nda-forge-pinning 2025.04.20.22.28.24
h-vetinari
force-pushed
the
rebuild-absl_grpc_proto-0-1_hbe565e
branch
from
6d68cae to
8901238
Compare
Member
|
@simia, I backported your upstream PR in conda-forge/grpc-cpp-feedstock#403, thanks a lot! We get a lot further now, but it still fails which seems to be similarly affected by the windows macro shenanigans. |
copybara-service bot
pushed a commit
to grpc/grpc
that referenced
this pull request
Apr 25, 2025
#38474 added protection from unwanted macros to the header files. This PR adds the same protection to the source files. Without protection both in header and source files the code containing system macros will not compile. Macros will apply to function names in cc files and those will start to differ from the ones in header files. This solves issues like described here: conda-forge/google-cloud-cpp-feedstock#196 Closes #39266 COPYBARA_INTEGRATE_REVIEW=#39266 from simia:protect_cc_files 3323fba PiperOrigin-RevId: 751501020
eugeneo
pushed a commit
to eugeneo/grpc
that referenced
this pull request
Apr 28, 2025
grpc#38474 added protection from unwanted macros to the header files. This PR adds the same protection to the source files. Without protection both in header and source files the code containing system macros will not compile. Macros will apply to function names in cc files and those will start to differ from the ones in header files. This solves issues like described here: conda-forge/google-cloud-cpp-feedstock#196 Closes grpc#39266 COPYBARA_INTEGRATE_REVIEW=grpc#39266 from simia:protect_cc_files 3323fba PiperOrigin-RevId: 751501020
pawbhard
pushed a commit
to pawbhard/grpc
that referenced
this pull request
May 6, 2025
grpc#38474 added protection from unwanted macros to the header files. This PR adds the same protection to the source files. Without protection both in header and source files the code containing system macros will not compile. Macros will apply to function names in cc files and those will start to differ from the ones in header files. This solves issues like described here: conda-forge/google-cloud-cpp-feedstock#196 Closes grpc#39266 COPYBARA_INTEGRATE_REVIEW=grpc#39266 from simia:protect_cc_files 3323fba PiperOrigin-RevId: 751501020
pawbhard
pushed a commit
to pawbhard/grpc
that referenced
this pull request
May 6, 2025
grpc#38474 added protection from unwanted macros to the header files. This PR adds the same protection to the source files. Without protection both in header and source files the code containing system macros will not compile. Macros will apply to function names in cc files and those will start to differ from the ones in header files. This solves issues like described here: conda-forge/google-cloud-cpp-feedstock#196 Closes grpc#39266 COPYBARA_INTEGRATE_REVIEW=grpc#39266 from simia:protect_cc_files 3323fba PiperOrigin-RevId: 751501020
veblush
pushed a commit
to grpc/grpc
that referenced
this pull request
May 6, 2025
…em macros (#39266) (#39484) #38474 added protection from unwanted macros to the header files. This PR adds the same protection to the source files. Without protection both in header and source files the code containing system macros will not compile. Macros will apply to function names in cc files and those will start to differ from the ones in header files. This solves issues like described here: conda-forge/google-cloud-cpp-feedstock#196 Closes #39266 COPYBARA_INTEGRATE_REVIEW=#39266 from simia:protect_cc_files 3323fba PiperOrigin-RevId: 751501020 Co-authored-by: Tomasz Kaczkowski <[email protected]>
veblush
pushed a commit
to grpc/grpc
that referenced
this pull request
May 6, 2025
…em macros (#39266) (#39483) #38474 added protection from unwanted macros to the header files. This PR adds the same protection to the source files. Without protection both in header and source files the code containing system macros will not compile. Macros will apply to function names in cc files and those will start to differ from the ones in header files. This solves issues like described here: conda-forge/google-cloud-cpp-feedstock#196 Closes #39266 COPYBARA_INTEGRATE_REVIEW=#39266 from simia:protect_cc_files 3323fba PiperOrigin-RevId: 751501020 Co-authored-by: Tomasz Kaczkowski <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has been triggered in an effort to update absl_grpc_proto.
Notes and instructions for merging this PR:
Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.
If this PR was opened in error or needs to be updated please add the
bot-rerunlabel to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun botin a PR comment to have theconda-forge-adminadd it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/13845673470 - please use this URL for debugging.