-
-
Notifications
You must be signed in to change notification settings - Fork 33
[dev] Build using C++20
#272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ForgeAutomergeUpdate
…nda-forge-pinning 2022.11.29.22.58.17
…1d2043 libprotobuf v21.10
…nda-forge-pinning 2022.12.07.18.34.25
automerged PR by conda-forge/automerge-action
automerged PR by conda-forge/automerge-action
This reverts commit 31bcbc1.
…nda-forge-pinning 2023.02.06.13.55.07
…nda-forge-pinning 2023.02.16.23.42.32
…nda-forge-pinning 2023.05.12.17.26.46
also documented as such in the upstream documentation: https://github.com/protocolbuffers/protobuf/blob/main/cmake/README.md#testing
…2ce1c libprotobuf v32.1
…f6f50 libprotobuf v33.0
|
@conda-forge-admin, please rerender |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/19308273189. Examine the logs at this URL for more detail. |
|
Rather than just synchronize (which is fair enough), let that be the baseline for the work you want to try out on the dev branch, in this same PR. |
Signed-off-by: Julien Jerphanion <[email protected]>
|
Done, I mostly want to try using C++20. I guess C++20 for builds on main (as proposed by #270) won't be accepted because it would constrained dependent projects, isn't it? |
#270 looks like an exploration, not a proposal (which would need explanation why this is necessary/desirable). I'm fine to test this on the dev branch, though be aware that this version is currently not compatible with anything else; we can't migrate to it until conda-forge/grpc-cpp-feedstock#411 is solved, which is blocked on upstream compatibility of grpc with newer protobuf |
|
In a nutshell, ArcticDB uses C++20, there are linker errors in Windows with libprotobuf, relevant issues opened upstream suggest to rebuild libprotobuf with C++20. I want to test whether this resolves the issue or not. |
|
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)Alternative to #269 using
mergeinstead ofgit checkoutto get the absolute difference.See the absolute diff of this branch and
upstream:mainwhich only consists of changes for the usingconda-forge libprotobuf_devas thechannel_target.Closes #269.