Skip to content

Conversation

@jjerphan
Copy link
Member

@jjerphan jjerphan commented Nov 12, 2025

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Alternative to #269 using merge instead of git checkout to get the absolute difference.

See the absolute diff of this branch and upstream:main which only consists of changes for the using conda-forge libprotobuf_dev as the channel_target.

Closes #269.

conda-forge-curator bot and others added 30 commits November 2, 2022 19:12
automerged PR by conda-forge/automerge-action
automerged PR by conda-forge/automerge-action
@jjerphan
Copy link
Member Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Nov 12, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.
  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/19308273189. Examine the logs at this URL for more detail.

@jjerphan jjerphan marked this pull request as ready for review November 12, 2025 18:33
@jjerphan jjerphan added the automerge Merge the PR when CI passes label Nov 12, 2025
@h-vetinari
Copy link
Member

Rather than just synchronize (which is fair enough), let that be the baseline for the work you want to try out on the dev branch, in this same PR.

@jjerphan jjerphan removed the automerge Merge the PR when CI passes label Nov 12, 2025
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan
Copy link
Member Author

Done, I mostly want to try using C++20.

I guess C++20 for builds on main (as proposed by #270) won't be accepted because it would constrained dependent projects, isn't it?

@h-vetinari h-vetinari changed the title [dev] Synchronize dev with main [dev] Build using C++20 Nov 12, 2025
@jjerphan jjerphan mentioned this pull request Nov 12, 2025
5 tasks
@h-vetinari
Copy link
Member

C++20 for builds on main (as proposed by #270)

#270 looks like an exploration, not a proposal (which would need explanation why this is necessary/desirable). I'm fine to test this on the dev branch, though be aware that this version is currently not compatible with anything else; we can't migrate to it until conda-forge/grpc-cpp-feedstock#411 is solved, which is blocked on upstream compatibility of grpc with newer protobuf

@jjerphan
Copy link
Member Author

jjerphan commented Nov 12, 2025

In a nutshell, ArcticDB uses C++20, there are linker errors in Windows with libprotobuf, relevant issues opened upstream suggest to rebuild libprotobuf with C++20.

I want to test whether this resolves the issue or not.

@jjerphan jjerphan added the automerge Merge the PR when CI passes label Nov 12, 2025
@conda-forge-admin conda-forge-admin merged commit 22cec97 into conda-forge:dev Nov 12, 2025
9 checks passed
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Merge the PR when CI passes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants