Skip to content

Patch to fix Python 3.12 compatibility (also will break Python 2)#7

Closed
vladsavelyev wants to merge 5 commits intoconda-forge:mainfrom
vladsavelyev:python312-patch
Closed

Patch to fix Python 3.12 compatibility (also will break Python 2)#7
vladsavelyev wants to merge 5 commits intoconda-forge:mainfrom
vladsavelyev:python312-patch

Conversation

@vladsavelyev
Copy link
Contributor

@vladsavelyev vladsavelyev commented Oct 12, 2023

lzstring breaks on Python 3.12:

  File "/miniconda3/envs/py3.12/lib/python3.12/site-packages/lzstring/__init__.py", line 11, in <module>
    from future import standard_library
  File "/miniconda3/envs/py3.12/lib/python3.12/site-packages/future/standard_library/__init__.py", line 65, in <module>
    import imp
ModuleNotFoundError: No module named 'imp'

From MultiQC/MultiQC#2112 (comment)

This patch fixes this. This future import was needed only for Python 2 compatibility, which is unlikely needed now days? If not, we can wrap this in an if-else block.

(also filed a PR into the lz-string-python package as well gkovacs/lz-string-python#6)

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • license_file entry is missing, but is required.
  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

For recipe:

@vladsavelyev
Copy link
Contributor Author

@conda-forge-admin, please rerender

conda-forge-webservices[bot] and others added 2 commits October 12, 2023 18:27
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

@ewels ewels mentioned this pull request Jan 1, 2025
@ewels
Copy link
Member

ewels commented Jan 1, 2025

Got this working in #9

@ewels ewels closed this Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants