Skip to content

Fix version string#82

Open
AreWeDreaming wants to merge 6 commits intoconda-forge:mainfrom
AreWeDreaming:fix_version_string
Open

Fix version string#82
AreWeDreaming wants to merge 6 commits intoconda-forge:mainfrom
AreWeDreaming:fix_version_string

Conversation

@AreWeDreaming
Copy link
Contributor

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

This fixes the MDSplus.__version__ string to be correctly reflecting the MDSplus version. This was verified to work for MDSplus built with build_locally.py

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Feb 11, 2026

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.
  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/21892213335. Examine the logs at this URL for more detail.

@AreWeDreaming
Copy link
Contributor Author

Ok so this now accomplishes the primary goal of getting a PEP compliant version into the MDSPlus package.

Python 3.11.14 | packaged by conda-forge | (main, Jan 26 2026, 23:48:32) [GCC 14.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
Ctrl click to launch VS Code Native REPL
>>> import MDSplus
Warning:
  The MDSplus python module version (7.157.0) does not match
  the version of the installed MDSplus libraries (alpha_release-7-157-0).
  Upgrade the module using the mdsplus/python/MDSplus directory of the
  MDSplus installation or set PYTHONPATH=/usr/local/mdsplus/python.
>>> MDSplus.__version__
'7.157.0'

However, there is the obvious error message that is undesirable. Removing it is possible but this requires a level of hacking of the original MDSplus source that takes it a little too far. I have created MDSplus/mdsplus#3023 in the hopes of getting a nice, PEP-compliant __version__ in the future.
@smithsp for OMFIT the . separated version is required but the warning is obviously not great. I leave it to you on whether you would want to merge this.

@smithsp
Copy link
Contributor

smithsp commented Feb 11, 2026

@AreWeDreaming Thanks for attempting something here. I think it is worth trying to keep the alpha... in the version string, if that is how MDSplus is labeling it. We should try to get OMFIT to handle the full string (including stripping the text and converting dashes to periods).
Do we get a warning printed now when OMFIT starts? I don't think so. But then again, it might still be pinned on the much older version of MDSplus.

@AreWeDreaming
Copy link
Contributor Author

@smithsp That would still not be PEP 440 compliant. What we can do is add an aN to the end to indicate that this is an alpha release. I can do this for the fix here.

If I am interpreting the response at MDSplus/mdsplus#3023 correctly then we might get a PEP compliant versions string in future releases of MDSplus so I am hopeful that this will be a one-time manual touch up that we do not have to worry about in the future.
We can probably dress the MDSPlus imports with warning suppressions to avoid this in the meantime. Without that the warning was very visible when testing omfit_classes yesterday.

@smithsp
Copy link
Contributor

smithsp commented Feb 11, 2026

Sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants