Conversation
- Also increment build number
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/21892213335. Examine the logs at this URL for more detail. |
|
Ok so this now accomplishes the primary goal of getting a PEP compliant version into the MDSPlus package. However, there is the obvious error message that is undesirable. Removing it is possible but this requires a level of hacking of the original MDSplus source that takes it a little too far. I have created MDSplus/mdsplus#3023 in the hopes of getting a nice, PEP-compliant |
|
@AreWeDreaming Thanks for attempting something here. I think it is worth trying to keep the |
|
@smithsp That would still not be PEP 440 compliant. What we can do is add an If I am interpreting the response at MDSplus/mdsplus#3023 correctly then we might get a PEP compliant versions string in future releases of MDSplus so I am hopeful that this will be a one-time manual touch up that we do not have to worry about in the future. |
|
Sounds good. |
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)This fixes the
MDSplus.__version__string to be correctly reflecting the MDSplus version. This was verified to work for MDSplus built withbuild_locally.py