Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .scripts/build_steps.sh

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 3 additions & 7 deletions recipe/build-mpi.sh
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ unset FFLAGS F77 F90 F95
wrapper_ldflags="-L$PREFIX/lib -Wl,-rpath,$PREFIX/lib"
export LIBRARY_PATH="$PREFIX/lib"
if [[ "$target_platform" == osx-* ]]; then
# FIXME: remove autogen when autotools patch no longer required
perl autogen.pl --force
Copy link
Contributor

@dalcinl dalcinl Jul 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then we need the perl dependency in the recipe? Sorry, IIRC I removed it a while ago because it was no longer needed.

if [[ -n "$CONDA_BUILD_SYSROOT" ]]; then
export CFLAGS="$CFLAGS -isysroot $CONDA_BUILD_SYSROOT"
export CXXFLAGS="$CXXFLAGS -isysroot $CONDA_BUILD_SYSROOT"
Expand Down Expand Up @@ -61,6 +63,7 @@ fi
--enable-mpi-fortran \
--disable-wrapper-rpath \
--disable-wrapper-runpath \
--with-mpi-moduledir="$PREFIX/include" \
--with-wrapper-cflags="-I$PREFIX/include" \
--with-wrapper-cxxflags="-I$PREFIX/include" \
--with-wrapper-fcflags="-I$PREFIX/include" \
Expand All @@ -78,13 +81,6 @@ fi
make -j"${CPU_COUNT:-1}"
make install

# openmpi installs .mod files in the wrong prefix (/lib instead of /include)
# symlink instead of copy to avoid breaking anything (unlikely)
for f in $PREFIX/lib/*.mod; do
modname=$(basename "$f")
ln -sv "../lib/${modname}" "$PREFIX/include/${modname}"
done

POST_LINK=$PREFIX/bin/.openmpi-post-link.sh
if [ -n "$build_with_ucx" ]; then
echo "setting MCA pml to ^ucx..."
Expand Down
31 changes: 31 additions & 0 deletions recipe/ldflags-mac.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
From e70f0a4afb1277e52389267777d260229b468ec0 Mon Sep 17 00:00:00 2001
From: Min RK <[email protected]>
Date: Mon, 29 Jul 2024 12:50:59 +0200
Subject: [PATCH] typo in LDFLAGS_save_xcode variable name

resulted in effectively overriding LDFLAGS='' on mac
---
config/ompi_setup_fc.m4 | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/config/ompi_setup_fc.m4 b/config/ompi_setup_fc.m4
index 53c3cd96da..c147bf2b60 100644
--- a/config/ompi_setup_fc.m4
+++ b/config/ompi_setup_fc.m4
@@ -212,11 +212,11 @@ end program
AS_IF([test $xcode_happy -eq 1],
[ # Restore LDFLAFGS + the new flags (i.e., get rid of the
# "-L." we added for this test)
- LDFLAGS="$LDFLAGS_xcode_save $1"
+ LDFLAGS="$LDFLAGS_save_xcode $1"
$2],
[ # If we failed the test, reset LDFLAGS back to its
# original value.
- LDFLAGS=$LDFLAGS_xcode_save
+ LDFLAGS=$LDFLAGS_save_xcode
$3])

OPAL_VAR_SCOPE_POP
--
2.45.0

13 changes: 8 additions & 5 deletions recipe/meta.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{% set version = "5.0.3" %}
{% set version = "5.0.5" %}
{% set major = version.rpartition('.')[0] %}
{% set cuda_major = (cuda_compiler_version|default("11.8")).rpartition('.')[0] %}
{% set build = 10 %}
{% set build = 0 %}

# give conda package a higher build number
{% if mpi_type == 'conda' %}
Expand All @@ -16,7 +16,9 @@ package:
source:
fn: openmpi-{{ version }}.tar.bz2
url: https://www.open-mpi.org/software/ompi/v{{ major }}/downloads/openmpi-{{ version }}.tar.bz2
sha256: 990582f206b3ab32e938aa31bbf07c639368e4405dca196fabe7f0f76eeda90b
sha256: 6588d57c0a4bd299a24103f4e196051b29e8b55fbda49e11d5b3d32030a32776
patches:
- ldflags-mac.patch # [osx]

build:
number: {{ build }}
Expand Down Expand Up @@ -48,8 +50,9 @@ outputs:
- {{ compiler('cuda') }} # [cuda_compiler != "None"]
- {{ compiler('fortran') }}
- {{ stdlib('c') }}
#- autoconf # [unix]
#- automake # [unix]
# FIXME: autotools required for ldflags-mac.patch
- autoconf # [osx]
- automake # [osx]
- libtool # [unix]
- make # [unix]
host:
Expand Down
2 changes: 0 additions & 2 deletions recipe/run_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,6 @@ if [[ $PKG_NAME == "openmpi" ]]; then
$MPIEXEC -n 4 ./helloworld.sh

test -f $PREFIX/include/mpi.mod
# keep duplicates in original location for now
test -f $PREFIX/lib/mpi.mod
fi

if [[ $PKG_NAME == "openmpi-mpicc" ]]; then
Expand Down