-
-
Couldn't load subscription status.
- Fork 27
Open up compiler version bound for wrappers #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open up compiler version bound for wrappers #194
Conversation
|
@conda-forge-admin, please rerender |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/14471976960. Examine the logs at this URL for more detail. |
…nda-forge-pinning 2025.04.13.21.56.35
|
@LourensVeen Any chance that something like EDIT: Maybe this way? |
|
Can't hurt to try :) |
0089d69 to
70a0d36
Compare
|
Hi! This is the friendly automated conda-forge-linting service. I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/14473713111. Examine the logs at this URL for more detail. |
70a0d36 to
354ec4d
Compare
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/14594495764. Examine the logs at this URL for more detail. |
|
Looks like it's working now, except that one of the tests failed because a download failed. Is there any way I could access the built packages to see if the dependency is now actually what we want? |
|
You can store artifacts using |
|
@conda-forge-admin, please rerender |
…nda-forge-pinning 2025.04.16.03.46.51
|
Okay, I have stored and downloaded the alien artifacts, then installed them locally with dependencies from conda-forge, and I've compiled and run C, C++ and Fortran test programs with gcc 11.4.0, 12.4.0, 13.3.0, and 14.2.0, which works fine at least on linux-64. Just for fun, I also tried clang-20 and clangxx-20 with OMPI_CC and OMPI_CXX, and that works too in case someone wants it. The dependencies now look like this: which is what we intended. There are still a couple of build failures due to network timeouts, those seem to be fairly common. Do I keep retrying until it passes? |
|
@conda-forge-admin, please restart ci |
|
Before merging, I think we have to revert/remove 32aaadc. EDIT: Actually, maybe just set it to "false", such that the key is there in the config file if we ever need to turn that thing on again. |
|
@LourensVeen Are we all set? Should I merge once CI finishes? |
|
@conda-forge-admin, please rerender |
…nda-forge-pinning 2025.04.22.11.04.24
|
I think this is ready to go. It's a bit scary because I'm not used to working on stuff that's this widely used, but it works as far as I can test it, passes all the built-in tests as well, and has a positive review, so let's go for it 😄 |
Not to worry, and thanks for your contribution! The compiler wrapper packages aren't particularly widely used, since they are really empty wrappers for two packages, e.g.
but we currently don't do either of those, and I'm not sure we want to. |
|
Ah, I never realised that the actual |
|
It was a long time ago, but I think we were thinking of being able to use something like |
|
There's still an open issue (#110) about Feeding MPI support into a build system isn't as standardised as $CC though. The $AX_MPI macro for autoconf uses MPICC and CMake has its own different set of environment variables. Setting $CC may work if the build system is just a Makefile, but with something more complicated it could also mislead it into thinking there's no MPI. I've found just using For background, I'm working to get AMUSE into conda-forge. This is an astrophysics toolbox with some 60 codes in it that do a variety of calculations, written in C, C++, Fortran and CUDA, with MPI and OpenMP and OpenCL, and of varying vintage and quality, all wrapped in Python. In short, the perfect packaging problem 😄. Of course none of it was designed with packaging or binary distribution in mind, but it's also old and crufty and hard to compile, making packaging more important. On the other hand, the codes aren't always written to be runtime configurable either, and the retrofit of that isn't always complete, so sometimes you want to modify the code, which can be tricky if, like many of the users, you don't really know what a compiler is. So I'm trying to have the users set up a more or less standardised build environment using conda-forge which then also matches conda-forge's build environment closely, so that mixing binary packages from conda-forge with locally-built packages for some of the codes can work, and also so that any contributions from users are less likely to build the conda-forge builds. When I get around to submitting some feedstocks that is. For some of these codes setting CC to the MPI compiler is just what's needed, but most of them need something more complicated, and I fear it's probably similar across the computational science/HPC domain... |
|
Yeah, that's why I don't really think The only real problem |
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)Closes #193.
This implements the fix proposed in the discussion for #193, setting the present compiler version as the minimum and removing the upper bound.
I'd love a 4.x series build with this fix too, for my current project 5.x seems to be working fine, but I've run into issues with 5.x in another context. I guess I'm asking for #192 really, but that's going a bit beyond my conda-fu I fear.