-
-
Notifications
You must be signed in to change notification settings - Fork 108
Use sysconfigdata and build-details.json from shared library build
#842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Use the sysconfigdata from the shared library build rather than the static one. The main difference is that this ensures that programs link to the shared Python library rather than the static library. Other differences are mostly superficial (build directories, test invocation commands). Fixes conda-forge#565 Signed-off-by: Michał Górny <[email protected]>
…6.01.13.21.47.52 Other tools: - conda-build 25.11.1 - rattler-build 0.55.0 - rattler-build-conda-compat 1.4.10
Signed-off-by: Michał Górny <[email protected]>
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/21076555700. Examine the logs at this URL for more detail. |
Signed-off-by: Michał Górny <[email protected]>
|
Okay, so:
|
|
Oh wait, that's for 3.15+ only. |
Now python3-config defaults to shared linking, so perform that part of the test first. Then remove the shared libraries to force static linking. Signed-off-by: Michał Górny <[email protected]>
|
Ok, it's green now. |
| requires: | ||
| - {{ stdlib('c') }} | ||
| - {{ compiler('c') }} | ||
| - ripgrep |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leftover from debugging?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it's actually used in tests. However, it was listed only for python output and was missing for libpython-static.
isuruf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is gonna make recipes like uWSGI link to the shared python library instead of the static library from a build number bump.
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)Use the sysconfigdata from the shared library build rather than the static one. The main difference is that this ensures that programs link to the shared Python library rather than the static library. Other differences are mostly superficial (build directories, test invocation commands).
Also use the
build-details.jsonfrom there. Unlike the static build version, it has all the data, including static and shared library, and extension build details.Fixes #565