Skip to content

Commit 577b637

Browse files
committed
re-enable torchinductor tests on osx; remove skips
1 parent 6c50e6a commit 577b637

File tree

1 file changed

+1
-21
lines changed

1 file changed

+1
-21
lines changed

recipe/meta.yaml

Lines changed: 1 addition & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -423,13 +423,9 @@ outputs:
423423
]) %}
424424
# tests torch.compile; avoid on aarch because it adds >4h in test runtime in emulation;
425425
# they add a lot of runtime (15->60min on windows), so run them for only one python version
426-
{% set tests = tests ~ " test/inductor/test_torchinductor.py" %} # [py==312 and not (aarch64 or osx)]
426+
{% set tests = tests ~ " test/inductor/test_torchinductor.py" %} # [py==312 and not aarch64]
427427

428428
{% set skips = "(TestTorch and test_print)" %}
429-
# minor tolerance violations
430-
{% set skips = skips ~ " or test_1_sized_with_0_strided_cpu_float32" %} # [osx]
431-
{% set skips = skips ~ " or test_batchnorm_nhwc_cpu" %} # [unix]
432-
{% set skips = skips ~ " or test_layer_norm_backwards_eps" %} # [unix]
433429
# timeouts and failures on aarch, see https://github.com/conda-forge/pytorch-cpu-feedstock/pull/298#issuecomment-2555888508
434430
{% set skips = skips ~ " or test_pynode_destruction_deadlock" %} # [aarch64]
435431
{% set skips = skips ~ " or (TestLinalgCPU and test_cholesky_cpu_float32)" %} # [aarch64]
@@ -446,12 +442,6 @@ outputs:
446442
{% set skips = skips ~ " or test_addbmm or test_baddbmm or test_bmm" %} # [aarch64]
447443
# doesn't crash, but gets different result on aarch + CUDA
448444
{% set skips = skips ~ " or illcondition_matrix_input_should_not_crash_cpu" %} # [aarch64 and cuda_compiler_version != "None"]
449-
# may crash spuriously
450-
{% set skips = skips ~ " or (TestAutograd and test_profiler_seq_nr)" %}
451-
{% set skips = skips ~ " or (TestAutograd and test_profiler_propagation)" %}
452-
# tests that fail due to resource clean-up issues (non-unique temporary libraries), see
453-
# https://github.com/conda-forge/pytorch-cpu-feedstock/pull/318#issuecomment-2620080859
454-
{% set skips = skips ~ " or test_mutable_custom_op_fixed_layout" %}
455445
# trivial accuracy problems
456446
{% set skips = skips ~ " or test_BCELoss_weights_no_reduce_cuda" %} # [linux and cuda_compiler_version != "None"]
457447
{% set skips = skips ~ " or test_ctc_loss_cudnn_tensor_cuda" %} # [linux and cuda_compiler_version != "None"]
@@ -483,10 +473,6 @@ outputs:
483473
{% set skips = skips ~ " or (TestLinalgCPU and test_inverse_errors_large_cpu)" %} # [linux and blas_impl == "mkl" and cuda_compiler_version != "None"]
484474
# non-MKL problems
485475
{% set skips = skips ~ " or test_gather_scatter_cpu or test_index_put2_cpu" %} # [linux and blas_impl != "mkl" and cuda_compiler_version != "None"]
486-
# these tests are failing with low -n values
487-
{% set skips = skips ~ " or test_base_does_not_require_grad_mode_nothing" %}
488-
{% set skips = skips ~ " or test_base_does_not_require_grad_mode_warn" %}
489-
{% set skips = skips ~ " or test_composite_registered_to_cpu_mode_nothing" %}
490476
# these tests are failing on windows
491477
{% set skips = skips ~ " or (TestMkldnnCPU and test_batch_norm_2d_cpu)" %} # [win]
492478
{% set skips = skips ~ " or (TestNN and test_Conv1d_dilated)" %} # [win]
@@ -499,12 +485,6 @@ outputs:
499485
{% set skips = skips ~ " or (TestNN and test_Conv3d_pad_same_dilated)" %} # [win]
500486
{% set skips = skips ~ " or (TestNN and test_Conv3d_stride)" %} # [win]
501487
{% set skips = skips ~ " or (TestNN and test_Conv3d_stride_padding)" %} # [win]
502-
# flaky test, fragile to GC behavior
503-
{% set skips = skips ~ " or (TestTorch and test_tensor_cycle_via_slots)" %}
504-
# unexpected success
505-
{% set skips = skips ~ " or test_forward_nn_Bilinear_mps_float16" %} # [osx and arm64]
506-
# "quantized engine NoQEngine is not supported"
507-
{% set skips = skips ~ " or test_qengine" %} # [osx and arm64]
508488

509489
# the whole test suite takes forever, but we should get a good enough coverage
510490
# for potential packaging problems by running a fixed subset

0 commit comments

Comments
 (0)