- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 50
Allow "generic" BLAS builds with CUDA enabled #292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
As discussed in: conda-forge#177 (comment)
…nda-forge-pinning 2024.11.22.09.17.35
| Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml: 
 This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11975477750. Examine the logs at this URL for more detail. | 
| - python * # [megabuild] | ||
| - numpy * # [megabuild] | ||
| skip: true # [win] | ||
| skip: true # [cuda_compiler_version != "None" and linux64 and blas_impl != "mkl"] | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since that commit came after the rerender, you didn't actually create any new jobs?
Also, for the time we're debugging this, you might want to inverse this condition (only build CUDA+non-MKL) to save CI resources.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't affect available jobs — they were always there, they just terminate without building or producing any artifacts. And yes, that confused me too, so I've checked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, what happens is that some more complicated skip conditions don't get detected correctly by smithy (or are hard to specify so that this happens), which I guess is what happened here.
| have you confirmed that it works locally on a larger machine with docker? Using the python build locally py script? If so, Can you move to cirun so that we can run the Linux builds on the CI? | 
| 
 No, I've built it using  | 
| This was also included in #293 | 
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)Reenable generic BLAS when CUDA is used (#177), and disable CUDA 11.8 while at it, as discussed in that bug.