Skip to content

Conversation

@mgorny
Copy link
Contributor

@mgorny mgorny commented Nov 22, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Reenable generic BLAS when CUDA is used (#177), and disable CUDA 11.8 while at it, as discussed in that bug.

@mgorny mgorny changed the title Cuda other blas Allow "generic" BLAS builds with CUDA enabled Nov 22, 2024
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). Your recipe may not receive automatic updates and/or may not be compatible with conda-forge's infrastructure. Please check the logs for more information and ensure your recipe can be parsed.
  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. Your recipe may not receive automatic updates and/or may not be compatible with conda-forge's infrastructure. Please check the logs for more information and ensure your recipe can be parsed.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11975477750. Examine the logs at this URL for more detail.

- python * # [megabuild]
- numpy * # [megabuild]
skip: true # [win]
skip: true # [cuda_compiler_version != "None" and linux64 and blas_impl != "mkl"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since that commit came after the rerender, you didn't actually create any new jobs?

Also, for the time we're debugging this, you might want to inverse this condition (only build CUDA+non-MKL) to save CI resources.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't affect available jobs — they were always there, they just terminate without building or producing any artifacts. And yes, that confused me too, so I've checked.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, what happens is that some more complicated skip conditions don't get detected correctly by smithy (or are hard to specify so that this happens), which I guess is what happened here.

@hmaarrfk
Copy link
Contributor

have you confirmed that it works locally on a larger machine with docker? Using the python build locally py script?

If so, Can you move to cirun so that we can run the Linux builds on the CI?

@mgorny
Copy link
Contributor Author

mgorny commented Nov 23, 2024

have you confirmed that it works locally on a larger machine with docker? Using the python build locally py script?

No, I've built it using conda build directly, since I had a warm ccache for it. Building from scratch via Docker would take a few hours for me.

@mgorny mgorny mentioned this pull request Nov 25, 2024
5 tasks
@mgorny
Copy link
Contributor Author

mgorny commented Nov 28, 2024

This was also included in #293

@mgorny mgorny closed this Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants