-
-
Notifications
You must be signed in to change notification settings - Fork 50
Fix dot on MKL builds #399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Not sure why MKL_INTERFACE_LAYER used by libmkl_rt.so (linked to by numpy) would affect libmkl_intel_gf.so (linked to by pytorch). It didn't use to. Might be a bug/feature in newer MKL.
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/16190507878. Examine the logs at this URL for more detail. |
Something very strange about this though, because our current pytorch builds have a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, makes sense. The upstream code seems terribly fragile. I mean, apparently it checks whether cblas_sdot() is precise enough, decides that it's not and instead uses fallback that's even less precise?!
|
Like #396, this is still running into pytorch/pytorch#153737. Background: In the context of this failure happening in #393, I had found the unmerged pytorch/pytorch#127702, which didn't change anything, and we eventually did conda-forge/triton-feedstock#52; apparently that wasn't a complete fix. |
|
Interestingly, this is still not enough to fix the linalg issues: |
|
Should we use |
conda-forge/triton-feedstock@07a8ebb alone was not enough
Brown paperbag moment: when regenerating the patches I unintentionally reverted Isuru's changes 🤦 apologies |
|
Pushed a missing build number bump: 2a435a7 |
|
Documenting the windows copy operation (after ensuring old uploads in my channel are not under $ gh run download 16209749249 --repo conda-forge/pytorch-cpu-feedstock --name conda_artifacts_16209749249_win_64_channel_targetsconda-forge_maincu_hca575dce
$ unzip pytorch-cpu-feedstock_conda_artifacts_.zip
$ cd bld/win-64
$ rm current_repodata.json index.html repodata*
$ ls
libtorch-2.7.1-cuda128_mkl_hca3f899_302.conda pytorch-2.7.1-cuda128_mkl_py313_h46e6c8c_302.conda
pytorch-2.7.1-cuda128_mkl_py310_h124cda0_302.conda pytorch-2.7.1-cuda128_mkl_py39_hecd1aea_302.conda
pytorch-2.7.1-cuda128_mkl_py311_h4f3c550_302.conda pytorch-gpu-2.7.1-cuda128_mkl_h2fd0c33_302.conda
pytorch-2.7.1-cuda128_mkl_py312_hc8193e8_302.conda
$ ls | xargs anaconda upload
$ DELEGATE=h-vetinari
PACKAGE_VERSION=2.7.1
for package in libtorch pytorch pytorch-gpu; do
anaconda copy --from-label main --to-label main --to-owner conda-forge ${DELEGATE}/${package}/${PACKAGE_VERSION}
done |
Not sure why MKL_INTERFACE_LAYER used by libmkl_rt.so (linked to by numpy) would affect libmkl_intel_gf.so (linked to by pytorch). It didn't use to. Might be a bug/feature in newer MKL.
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)