-
-
Notifications
You must be signed in to change notification settings - Fork 50
Fix Intel/LLVM openmp build #407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
isuruf
wants to merge
10
commits into
conda-forge:main
Choose a base branch
from
isuruf:kmp
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
20aa25c
Fix Intel/LLVM openmp build
isuruf c3d300d
use llvm openmp everywhere
isuruf e8228ab
skip not win
isuruf 245972f
debug
isuruf 29c2d5c
debug
isuruf 0a96b31
fix test
isuruf 1992483
try forwarding instead of copying
isuruf 4d1d683
no temp dir
isuruf 39fb3bc
remove debug
isuruf ef25adc
use clang-cl
isuruf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| From ffbdd8bb8fa38397ad6d7958a8c4ddd80ff738eb Mon Sep 17 00:00:00 2001 | ||
| From: Isuru Fernando <[email protected]> | ||
| Date: Thu, 31 Jul 2025 12:34:30 -0500 | ||
| Subject: [PATCH] Use Intel/LLVM openmp | ||
|
|
||
| This make MSVC use __kmp_* symbols available in both libiomp.dll | ||
| and libiomp5md.dll instead of vcomp* symbols which are only in | ||
| vcomp140.dll and libiomp5md.dll, but are missing in libiomp.dll | ||
| --- | ||
| cmake/Modules/FindOpenMP.cmake | 4 ++-- | ||
| 1 file changed, 2 insertions(+), 2 deletions(-) | ||
|
|
||
| diff --git a/cmake/Modules/FindOpenMP.cmake b/cmake/Modules/FindOpenMP.cmake | ||
| index 8a9abff398..336a9a927a 100644 | ||
| --- a/cmake/Modules/FindOpenMP.cmake | ||
| +++ b/cmake/Modules/FindOpenMP.cmake | ||
| @@ -122,9 +122,9 @@ function(_OPENMP_FLAG_CANDIDATES LANG) | ||
| set(OMP_FLAG_MIPSpro "-mp") | ||
| if(__header_dir MATCHES ".*Microsoft Visual Studio.*") | ||
| # MSVC header. No need to pass it as additional include. | ||
| - set(OMP_FLAG_MSVC "-openmp:experimental" "-openmp") | ||
| + set(OMP_FLAG_MSVC "-openmp:llvm" "-openmp:experimental" "-openmp") | ||
| else() | ||
| - set(OMP_FLAG_MSVC "-openmp:experimental -I${__header_dir}" "-openmp -I${__header_dir}") | ||
| + set(OMP_FLAG_MSVC "-openmp:llvm" "-openmp:experimental -I${__header_dir}" "-openmp -I${__header_dir}") | ||
| endif() | ||
| set(OMP_FLAG_PathScale "-openmp") | ||
| set(OMP_FLAG_NAG "-openmp") | ||
| -- | ||
| 2.45.2 | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.