Skip to content

Conversation

@iamthebot
Copy link

@iamthebot iamthebot commented Aug 6, 2025

This is basically #405 but with an additional patch file (0019) that backports a fix from PyTorch 2.7+ so tensorpipe compilation doesn't fail. This fixes the OSX build.

There are a few (4) test failures though that seem unrelated. Perhaps we can add this patch to #405?

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Aug 6, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.
  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/17363174359. Examine the logs at this URL for more detail.

@h-vetinari h-vetinari changed the base branch from main to v2.6.x August 12, 2025 02:22
@h-vetinari h-vetinari changed the title Fix OSX Builds for Cuda 12.9/Pytorch 2.6.0 upgrade [v2.6.x] Upgrade to CUDA 12.9, fix osx builds Aug 12, 2025
@h-vetinari
Copy link
Member

There are a few (4) test failures though that seem unrelated.

Can you please provide the logs / test traces where you saw this? We can add skips where the failures are not critical

@iamthebot
Copy link
Author

iamthebot commented Aug 13, 2025

There are a few (4) test failures though that seem unrelated.

Can you please provide the logs / test traces where you saw this? We can add skips where the failures are not critical

Seems to be the same 4 tests on all the OSX runners:

FAILED [0.0042s] test/test_linalg.py::TestLinalgCPU::test_norm_matrix_degenerate_shapes_cpu_complex128 - AssertionError: ValueError not raised

To execute this test, run the following from the base repo dir:
    python test/test_linalg.py TestLinalgCPU.test_norm_matrix_degenerate_shapes_cpu_complex128

This message can be suppressed by setting PYTORCH_PRINT_REPRO_ON_FAILURE=0
FAILED [0.0037s] test/test_linalg.py::TestLinalgCPU::test_norm_matrix_degenerate_shapes_cpu_complex64 - AssertionError: ValueError not raised

To execute this test, run the following from the base repo dir:
    python test/test_linalg.py TestLinalgCPU.test_norm_matrix_degenerate_shapes_cpu_complex64

This message can be suppressed by setting PYTORCH_PRINT_REPRO_ON_FAILURE=0
FAILED [0.0041s] test/test_linalg.py::TestLinalgCPU::test_norm_matrix_degenerate_shapes_cpu_float32 - AssertionError: ValueError not raised

To execute this test, run the following from the base repo dir:
    python test/test_linalg.py TestLinalgCPU.test_norm_matrix_degenerate_shapes_cpu_float32

This message can be suppressed by setting PYTORCH_PRINT_REPRO_ON_FAILURE=0
FAILED [0.0063s] test/test_linalg.py::TestLinalgCPU::test_norm_matrix_degenerate_shapes_cpu_float64 - AssertionError: ValueError not raised

Let me take a closer look tomorrow and see if these are safe/reasonable to skip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants