-
-
Notifications
You must be signed in to change notification settings - Fork 15
Release 2.237.3, allow grayskull updates, relax cloudpickle pin #315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe/meta.yaml:
For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12776370400. Examine the logs at this URL for more detail. |
…onda-forge-pinning 2025.01.11.16.15.44
…hon-sdk-feedstock into release-v2.237.3
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12776416588. Examine the logs at this URL for more detail. |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
…onda-forge-pinning 2025.01.11.16.15.44
Import tests are failing like this:
It appears that some bits of this library were recently broken out into a separate package called There doesn't appear to be a package by that name yet on conda-forge. Hoping a repo maintainer here could add that, following the steps at https://conda-forge.org/docs/maintainer/adding_pkgs/, or suggest some other way around this. |
Thanks for doing this @jameslamb . Are you looking into the build failures? It seems like we need to have https://pypi.org/project/sagemaker-core/ published to conda-forge as well and have that added as a dependency. I can reach out to sagemaker-python-sdk team for this. Currently failing with
|
I just saw you commented basically the same thing right before me 😄 working on getting sagemaker-core added to conda-forge. |
So there are 2 things we can consider:
If this is a totally different package and there isn't much overlap, 1 can be a good choice If there is more overlap (like shared dependencies with common pinning needs), 2 can be a reasonable choice as it keeps all the pieces in one place James as you have dug into this more, do you have a sense of which case it sounds more like? |
sagemaker-python-sdk dependencies: https://github.com/aws/sagemaker-python-sdk/blob/master/pyproject.toml#L33-L59 I was thinking since they have different dependencies and different release cadence/versioning, it would make sense to have separate feedstocks. Though I don't have a ton of experience here in managing more complex conda-forge feedstocks. I created conda-forge/staged-recipes#28839 for adding sagemaker-core recipe. |
Thanks Clayton and James! 🙏 Let's try restarting now that the package is up and on CDN @conda-forge-admin , please restart CI |
Just updated your branch as well to add sagemaker-core and update other dependencies |
thanks so much for this @claytonparnell !!! |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)Details
Proposes updating to
v2.237.3
, the latest version on PyPI (https://pypi.org/project/sagemaker/#sagemaker-2.237.3.tar.gz).And relaxing the package's pin on
cloudpickle
, to match the changes from aws/sagemaker-python-sdk#4964.Also pulls over changes from #314 , based on the bot's suggestion at #315 (comment)