Skip to content

Conversation

@xhochy
Copy link
Member

@xhochy xhochy commented Nov 25, 2019

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/dagit, recipes/dagster, recipes/dagster_aws, recipes/dagster_bash, recipes/dagster_cron, recipes/dagster_dask, recipes/dagster_datadog, recipes/dagster_dbt, recipes/dagster_gcp, recipes/dagster_ge, recipes/dagster_graphql, recipes/dagster_pagerduty, recipes/dagster_pandas, recipes/dagster_papertrail, recipes/dagster_postgres, recipes/dagster_pyspark, recipes/dagster_slack, recipes/dagster_snowflake, recipes/dagster_spark, recipes/dagster_ssh, recipes/dagster_twilio, recipes/flask-sockets) and found some lint.

Here's what I've got...

For recipes/flask-sockets:

  • The recipe must have some tests.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/dagit, recipes/dagster, recipes/dagster_aws, recipes/dagster_bash, recipes/dagster_cron, recipes/dagster_dask, recipes/dagster_datadog, recipes/dagster_dbt, recipes/dagster_gcp, recipes/dagster_ge, recipes/dagster_graphql, recipes/dagster_pagerduty, recipes/dagster_pandas, recipes/dagster_papertrail, recipes/dagster_postgres, recipes/dagster_pyspark, recipes/dagster_slack, recipes/dagster_snowflake, recipes/dagster_spark, recipes/dagster_ssh, recipes/dagster_twilio, recipes/flask-sockets) and found it was in an excellent condition.

@xhochy xhochy marked this pull request as ready for review November 25, 2019 21:30
@xhochy
Copy link
Member Author

xhochy commented Nov 26, 2019

@conda-forge/staged-recipes This is ready for review/merge. The windows build is failing due to an encoding issue but the only non-noarch package passed and all others are noarch: python and thus will build fine on the feedstock.

@ocefpaf ocefpaf merged commit e7685b8 into conda-forge:master Nov 26, 2019
run:
- python
- dagster {{ version }}.*
- slackclient 1.3.1.*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be in the pinning packages?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants