Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/vsgImGui/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12939532261. Examine the logs at this URL for more detail. |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
70b6bf1 to
c320667
Compare
|
Hi! This is the friendly automated conda-forge-linting service. I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12940568043. Examine the logs at this URL for more detail. |
4eb2a85 to
72f21c4
Compare
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge/help-c-cpp, ready for review! It seems the linter error is unrelated, as I'm seeing the same error in other PRs (e.g., this one). However, if it's not unrelated, I would appreciate any help on this. |
| @@ -0,0 +1,66 @@ | |||
| {% set name = "vsgImGui" %} | |||
There was a problem hiding this comment.
The linter may be confused by the casing differences between the name and the run_exports.
There was a problem hiding this comment.
@xhochy I am facing the same issue. A change happened yesterday approximately 24 hours ago. I tested then a meta.yaml that worked a few hours before again, it gave the new error in the linter. Therefore, I suspect something on GitHub changed that makes the linter fail.
There was a problem hiding this comment.
Hm, I'm also suspicious that there might be something else that could have caused this, because it was fine with other recipes (e.g., https://github.com/conda-forge/staged-recipes/pull/28730/files#diff-907e125340dccaf73eebc0b636349abcafcff964d43b2fe8a8fd742bfa354da0R1)
There was a problem hiding this comment.
The linter error is gone rebasing to #28925!
| @@ -0,0 +1,5062 @@ | |||
| From 6d1dff24888a8ec3601fe0354dc94ea986a2ccb6 Mon Sep 17 00:00:00 2001 | |||
There was a problem hiding this comment.
This looks like a massive diff that could also be achieved by an rm … call. Can you use that instead? This should make maintenance simpler.
There was a problem hiding this comment.
Do you mean running rm ... in the build script instead or in meta.yaml, which I don't know how to? Alternatively, could I handle this after the feedstock repository is created? Ideally, these patches would be submitted to upstream (vsg-dev/vsgImGui#73) and the maintainer is positive about the change, so it could be addressed upstream hopefully soon.
There was a problem hiding this comment.
Removed this patch and used the rm commands in the build scripts
|
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
Checklist
url) rather than a repo (e.g.git_url) is used in your recipe (see here for more details).