Skip to content

Add smblmath recipe #30694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add smblmath recipe #30694

wants to merge 2 commits into from

Conversation

kaiserls
Copy link

@kaiserls kaiserls commented Jul 31, 2025

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/sbmlmath/meta.yaml:
    • lints:
      • The following maintainers have not yet confirmed that they are willing to be listed here: dweindl. Please ask them to comment on this PR if they are.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/sbmlmath/meta.yaml) and found it was in an excellent condition.

@kaiserls
Copy link
Author

kaiserls commented Jul 31, 2025

@conda-forge-admin, please ping team
@conda-forge/help-python

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/staged-recipes and so here I am doing that.

Copy link
Contributor

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/staged-recipes and so here I am doing that.

Copy link
Contributor

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

@kaiserls
Copy link
Author

@conda-forge/help-python


extra:
recipe-maintainers:
# GitHub IDs for maintainers of the recipe.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove this comment. We have a linter to check for consent.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are only waiting for dweindl consent to be added here so we can merge this.

@kaiserls kaiserls marked this pull request as draft August 4, 2025 21:44
@kaiserls
Copy link
Author

kaiserls commented Aug 4, 2025

@ocefpaf I just noticed that python-libsbml has platform specific distributions: https://anaconda.org/conda-forge/python-libsbml/files
I think the specifier noarch: python in my recipe is therefore not correct. Can you confirm this?

I could remove the specifier noarch: python and fix the dependencies or completely switch over to the v1 recipe below, which led me to the conclusion that my meta.yaml not well defined. The dependency on the non-build packages for the host environment is caused by setuptools-scm.

context:
  version: "0.4.0"

package:
  name: "sbmlmath"
  version: ${{ version }}

source:
  url: https://pypi.org/packages/source/s/sbmlmath/sbmlmath-${{ version }}.tar.gz
  sha256: 1c0c7b57b9bacef73bc0adc5443c1e2633ae1d2548086ab768fa2e7a03ac3c31

build:
  script:
    - python -m pip install . -vv --no-deps --no-build-isolation
  number: 0

requirements:
  host:
    - python >=3.9
    - setuptools >=64
    - setuptools-scm >=8
    - pip
    - python-libsbml >=5.20.4
    - sympy
    - pint
    - lxml >=4.6.4
  run:
    - python >=3.9
    - python-libsbml >=5.20.4
    - sympy
    - pint
    - lxml >=4.6.4

tests:
  - python:
      imports:
        - sbmlmath
      pip_check: true
  - script:
    - pytest ./tests
    requirements:
      run:
        - pytest
    files:
      source:
        - tests/


about:
  homepage: https://github.com/dweindl/sbmlmath
  summary: SBML Math <-> SymPy
  license: BSD-3-Clause
  license_file: LICENSE
  documentation: https://sbmlmath.readthedocs.io/en/latest/
  repository: https://github.com/dweindl/sbmlmath.git

extra:
  recipe-maintainers:
    - kaiserls
    - dweindl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants