Skip to content

draft: Add recipe for webkit2gtk4.1 #30699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

haecker-felix
Copy link
Contributor

@haecker-felix haecker-felix commented Aug 1, 2025

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Todo

  • Figure out what's the correct license (-file)
  • Package jpegxl and enable USE_JPEGXL flag
  • Figure out whether the USE_GBM flag should be enabled
  • Check whether USE_SYSTEM_SYSPROF_CAPTURE can stay disabled
  • Check what compile flags distros use (eg. fedora) to make sure we're not missing anything important here
  • Add some useful test
  • Package xdg-dbus-proxy / bubblewrap and enable USE_BUBBLEWRAP flag
  • Enable USE_GSTREAMER_TRANSCODER once gst-plugins-bad 1.26.3 is available
  • Package woff2 and enable USE_WOFF2 flag
  • Package hyphen and enable USE_SE_LIBHYPHEN flag

Depends on

@haecker-felix haecker-felix marked this pull request as draft August 1, 2025 12:50
Copy link
Contributor

github-actions bot commented Aug 1, 2025

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/webkit2gtk4.1/recipe.yaml:
    • lints:
      • The following maintainers have not yet confirmed that they are willing to be listed here: Hofer-Julian. Please ask them to comment on this PR if they are.

@haecker-felix haecker-felix mentioned this pull request Aug 1, 2025
13 tasks
@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Aug 1, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/webkit2gtk4.1/recipe.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/webkit2gtk4.1/recipe.yaml:

  • ℹ️ License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/16753734782. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Aug 5, 2025

Hi! This is the friendly automated conda-forge-linting service.

I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint --conda-forge . from the recipe directory. You can also examine the workflow logs for more detail.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/16803436060. Examine the logs at this URL for more detail.

@Hofer-Julian
Copy link
Contributor

I agree to be a maintainer of this package

Copy link
Contributor

github-actions bot commented Aug 8, 2025

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/webkit2gtk4.1/recipe.yaml) and found it was in an excellent condition.

@haecker-felix haecker-felix force-pushed the webkit2gtk4.1 branch 2 times, most recently from 7144b3f to b3430c2 Compare August 8, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants