Skip to content

Adding diffpy.srreal #30701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

Tieqiong
Copy link

@Tieqiong Tieqiong commented Aug 2, 2025

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint --conda-forge . from the recipe directory. You can also examine the workflow logs for more detail.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/16689553658. Examine the logs at this URL for more detail.

Copy link
Contributor

github-actions bot commented Aug 2, 2025

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/diffpy.srreal/meta.yaml:
    • lints:
      • The following maintainers have not yet confirmed that they are willing to be listed here: pavoljuhas, sbillinge. Please ask them to comment on this PR if they are.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/diffpy.srreal/meta.yaml) and found it was in an excellent condition.

@Tieqiong
Copy link
Author

Tieqiong commented Aug 2, 2025

@pavoljuhas @sbillinge please can you comment on this PR if you are willing to listed as a conda-forge maintainer for this package? Thanks!

@pavoljuhas
Copy link
Contributor

@pavoljuhas @sbillinge please can you comment on this PR if you are willing to listed as a conda-forge maintainer for this package? Thanks!

Hi @Tieqiong - please remove me from the list of maintainers.

@sbillinge
Copy link
Contributor

I am happy to be listed as a maintainer on this package

Copy link
Contributor

github-actions bot commented Aug 2, 2025

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/diffpy.srreal/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/diffpy.srreal/meta.yaml:

  • ℹ️ You should not need to depend on libboost directly. If your package is linking to boost libraries, use libboost-devel in the host environment (which will create the correct dependence at runtime through a run-export), or use libboost-headers if you only need the boost headers.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/16696645878. Examine the logs at this URL for more detail.

@Tieqiong
Copy link
Author

Tieqiong commented Aug 2, 2025

@conda-forge/help-python-c, ready for review!

@sbillinge
Copy link
Contributor

  • You should not need to depend on libboost directly. If your package is linking to boost libraries, use libboost-devel in the host environment (which will create the correct dependence at runtime through a run-export), or use libboost-headers if you only need the boost headers.

@Tieqiong The linter doesn't like this change, but this was needed for the CI to pass on windows, correct? If there is a way to make both the CI and the linter happy, we would be happy to hear it when it is reviewed by conda-forge

@Tieqiong
Copy link
Author

Tieqiong commented Aug 2, 2025

@sbillinge Exactly. I already tried 1. no boost in run and wait for run_exports, 2. include libboost-devel in run, and 3. include libboost in run. Windows build only like 3, or it'll bump into error:

Needed DSO Library/bin/boost_serialization.dll found in ['conda-forge/win-64::libboost==1.86.0=hb0986bb_3'] but ['conda-forge/win-64::libboost==1.86.0=hb0986bb_3'] not in reqs/run, (i.e. it is overlinking) (likely) or a missing dependency (less likely)

@Tieqiong
Copy link
Author

Tieqiong commented Aug 7, 2025

@conda-forge-admin, please ping team
Friendly ping 🙂

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/staged-recipes and so here I am doing that.

Copy link
Contributor

github-actions bot commented Aug 7, 2025

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

@sbillinge
Copy link
Contributor

@conda-forge-admin, please ping @conda-forge/help-python-c, ready for review!

Thanks so much

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/help-python-c, and so here I am doing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants