ENH: Add py-flowy #30704

HaoZeke · 2025-08-02T15:01:08Z

Checklist

HaoZeke · 2025-08-02T15:02:02Z

@amritagos @MSallermann can you confirm that you'll be co-maintainers for the conda-forge recipe?

github-actions · 2025-08-02T15:02:27Z

Hi! This is the staged-recipes linter and I found some lint.

It looks like some changes were made outside the recipes/ directory. To ensure everything runs smoothly, please make sure that recipes are only added to the recipes/ directory and no other files are changed.

If these changes are intentional (and you aren't submitting a recipe), please add a maintenance label to the PR.

File-specific lints and/or hints:

conda_build_config.yaml:
- lints:
  - Do not edit files outside of the recipes/ directory.

conda-forge-admin · 2025-08-02T15:02:42Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/pyflowy/meta.yaml) and found some lint.

Here's what I've got...

For recipes/pyflowy/meta.yaml:

❌ Non noarch packages should have python requirement without any version constraints.
❌ Non noarch packages should have python requirement without any version constraints.
❌ This recipe is using a compiler, which now requires adding a build dependence on {{ stdlib("c") }} as well. Note that this rule applies to each output of the recipe using a compiler. For further details, please see META: {{ stdlib("c") }} migration conda-forge.github.io#2102.
❌ In your conda_build_config.yaml, please change the name of MACOSX_DEPLOYMENT_TARGET, to c_stdlib_version!

_{This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/16694841401. Examine the logs at this URL for more detail.}

MSallermann · 2025-08-02T15:04:39Z

@amritagos @MSallermann can you confirm that you'll be co-maintainers for the conda-forge recipe?

Yes, I can confirm :)

amritagos · 2025-08-02T15:04:44Z

@amritagos @MSallermann can you confirm that you'll be co-maintainers for the conda-forge recipe?

Sure, I'll confirm! Thanks! :)

conda-forge-admin · 2025-08-02T15:14:40Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pyflowy/meta.yaml) and found it was in an excellent condition.

github-actions · 2025-08-02T15:15:58Z

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

conda-forge-admin · 2025-08-02T16:34:55Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/pyflowy/recipe.yaml) and found some lint.

Here's what I've got...

For recipes/pyflowy/recipe.yaml:

❌ requirements: build: xtensor < 0.25.0 should not contain a space between relational operator and the version, i.e. xtensor <0.25.0

For recipes/pyflowy/recipe.yaml:

ℹ️ Jinja2 variable references are suggested to take a ${{<one space><variable name><one space>}} form. See lines [38].

_{This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/16695590029. Examine the logs at this URL for more detail.}

conda-forge-admin · 2025-08-02T16:37:48Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pyflowy/recipe.yaml) and found it was in an excellent condition.

HaoZeke · 2025-08-02T16:50:04Z

Same error as #30703 (comment)

1 warning and 20 errors generated.
 │ │   [6/9] Compiling C++ object subprojects/flowy/libflowy.dylib.p/src_topography.cpp.o
 │ │   FAILED: [code=1] subprojects/flowy/libflowy.dylib.p/src_topography.cpp.o
 │ │   x86_64-apple-darwin13.4.0-clang++ -Isubprojects/flowy/libflowy.dylib.p -Isubprojects/flowy -I../subprojects/flowy -I../subprojects/flowy/thirdparty/tsl -Isubprojects/pdf_cpplib -I../subprojects/pdf_cpplib -I$PREFIX/include -I$BUILD_PREFIX/include -fvisibility=hidden -fvisibility-inlines-hidden -fdiagnostics-color=always -DNDEBUG -Wall -Winvalid-pch -Wextra -Wpedantic -std=c++20 -O3 -g -march=core2 -mtune=haswell -mssse3 -ftree-vectorize -fPIC -fstack-protector-strong -O2 -pipe -stdlib=libc++ -fvisibility-inlines-hidden -fmessage-length=0 -isystem $PREFIX/include -fdebug-prefix-map=$SRC_DIR=/usr/local/src/conda/pyflowy-0.0.1 -fdebug-prefix-map=$PREFIX=/usr/local/src/conda-prefix -D_FORTIFY_SOURCE=2 -isystem $PREFIX/include -mmacosx-version-min=10.13 -mmacosx-version-min=10.13 -Wno-unused-local-typedefs -Wno-array-bounds -ffast-math -fno-finite-math-only -fno-plt -Bsymbolic -DWITH_NETCDF -MD -MQ subprojects/flowy/libflowy.dylib.p/src_topography.cpp.o -MF subprojects/flowy/libflowy.dylib.p/src_topography.cpp.o.d -o subprojects/flowy/libflowy.dylib.p/src_topography.cpp.o -c ../subprojects/flowy/src/topography.cpp
 │ │   In file included from ../subprojects/flowy/src/topography.cpp:3:
 │ │   In file included from ../subprojects/flowy/flowy/include/topography.hpp:8:
 │ │   $BUILD_PREFIX/include/xtensor/xsort.hpp:297:27: warning: unused parameter 'data_end' [-Wunused-parameter]
 │ │     297 |             ConstRandomIt data_end,
 │ │         |                           ^
 │ │   In file included from ../subprojects/flowy/src/topography.cpp:4:
 │ │   In file included from ../subprojects/flowy/flowy/include/asc_file.hpp:4:
 │ │   ../subprojects/flowy/flowy/include/topography_file.hpp:33:65: error: 'path' is unavailable: introduced in macOS 10.15 unknown - see https://conda-forge.org/docs/maintainer/knowledge_base.html#newer-c-features-with-old-sdk
 │ │      33 |     std::filesystem::path handle_suffix( const std::filesystem::path & path_in )
 │ │         |

Upstream doesn't yet support macos either (officially, the pypi packages are not for macos either). For later.

conda-forge-admin · 2025-08-02T21:50:15Z

Hi! This is the friendly automated conda-forge-linting service.

I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint --conda-forge . from the recipe directory. You can also examine the workflow logs for more detail.

_{This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/16698483837. Examine the logs at this URL for more detail.}

conda-forge-admin · 2025-08-02T22:51:30Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pyflowy/recipe.yaml) and found it was in an excellent condition.

HaoZeke · 2025-08-02T23:01:06Z

@conda-forge/help-python-c, ready for review!

synapticarbors · 2025-08-09T21:14:18Z

recipes/pyflowy/LICENSE

@@ -0,0 +1,674 @@
+                    GNU GENERAL PUBLIC LICENSE


You should remove this file since it is included in the source distribution and conda/rattler will pick it up from there.

synapticarbors · 2025-08-09T21:16:39Z

recipes/pyflowy/recipe.yaml

+tests:
+  - python:
+      imports:
+        - pyflowy


you can remove the script section below and just add
pip_check: true. See:
https://rattler.build/latest/reference/recipe_file/#python-tests

synapticarbors · 2025-08-09T21:18:07Z

recipes/pyflowy/recipe.yaml

+context:
+  name: pyflowy
+  version: 0.0.1
+  build_num: 0


Instead of using context to set jinja variables for build_num and shasum, just set them explicitly below.

synapticarbors · 2025-08-09T21:18:56Z

recipes/pyflowy/recipe.yaml

+
+build:
+  skip:
+    - if: python < 3.9


Technically you don't need to have the python < 3.9 check since conda-forge only builds packages for python >=3.9

synapticarbors · 2025-08-09T21:19:18Z

recipes/pyflowy/recipe.yaml

+    - win
+    - osx
+  number: ${{ build_num }}
+  string: h${{ hash }}_${{ build_num }}


Don't set the build string. That's created automatically.

synapticarbors · 2025-08-09T21:21:15Z

recipes/pyflowy/recipe.yaml

+    - pybind11 >=2.12.0
+    - libnetcdf
+    - hdf5
+    - ${{ pin_compatible('numpy') }}


You can just change this to numpy. `pin_compatible is no longer needed:
https://conda-forge.org/docs/maintainer/knowledge_base/#building-against-numpy

I like to still include numpy explicitly in run, even though there is a run_exports from the numpy package.

synapticarbors · 2025-08-09T21:22:43Z

recipes/pyflowy/variants.yaml

@@ -0,0 +1,5 @@
+c_stdlib_version:


Unless there is a good reason to specify this, it is best to just use the conda-forge defaults. My suggestion would be to delete this file.

synapticarbors · 2025-08-09T21:27:08Z

recipes/pyflowy/recipe.yaml

+    - numpy
+    - libnetcdf
+    - hdf5
+    - ${{ compiler('c') }}


compiler(...) should go up in the build section. I believe host and build should be reorganized. There's several things that should be in the build_platform != target_platform section. The following recipe might be a good guide:
https://github.com/conda-forge/matplotlib-feedstock/blob/5da242b3aa49613299e2bc176011d22aac266bf3/recipe/meta.yaml

ENH: Add py-flowy

de37997

MAINT: Fixup grayskull cruft

f640006

HaoZeke force-pushed the addPyFlowy branch from 8b741d7 to f640006 Compare August 2, 2025 15:14

HaoZeke force-pushed the addPyFlowy branch from 0ddabe0 to 74b684d Compare August 2, 2025 15:33

MAINT: Fixup build requirements

f65fcc0

HaoZeke force-pushed the addPyFlowy branch from 74b684d to f65fcc0 Compare August 2, 2025 15:43

HaoZeke force-pushed the addPyFlowy branch from b6d659c to c3ba50f Compare August 2, 2025 16:36

This was referenced Aug 2, 2025

ENH: Add flowy stuff HaoZeke/rg-forge#1

Open

DOC: Mention the conda-forge thing flowy-code/pyflowy#10

Open

ENH: Rework to a working config

0d3fab7

HaoZeke force-pushed the addPyFlowy branch from c3ba50f to 0d3fab7 Compare August 2, 2025 16:40

MAINT: Use newer features with old SDK

281569c

HaoZeke force-pushed the addPyFlowy branch from 1d1f3dc to 281569c Compare August 2, 2025 21:15

HaoZeke force-pushed the addPyFlowy branch from f686476 to da1ecc9 Compare August 2, 2025 22:44

MAINT: Skip on osx for now

1159c1e

HaoZeke force-pushed the addPyFlowy branch from da1ecc9 to 1159c1e Compare August 2, 2025 22:49

github-actions bot added the python-c label Aug 2, 2025

github-actions bot added the review-requested label Aug 2, 2025

Merge branch 'main' into addPyFlowy

baea1b7

synapticarbors reviewed Aug 9, 2025

View reviewed changes

Uh oh!

ENH: Add py-flowy #30704

Are you sure you want to change the base?

ENH: Add py-flowy #30704

Uh oh!

Conversation

HaoZeke commented Aug 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

HaoZeke commented Aug 2, 2025

Uh oh!

github-actions bot commented Aug 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

conda-forge-admin commented Aug 2, 2025

Uh oh!

MSallermann commented Aug 2, 2025

Uh oh!

amritagos commented Aug 2, 2025

Uh oh!

conda-forge-admin commented Aug 2, 2025

Uh oh!

github-actions bot commented Aug 2, 2025

Uh oh!

conda-forge-admin commented Aug 2, 2025

Uh oh!

conda-forge-admin commented Aug 2, 2025

Uh oh!

HaoZeke commented Aug 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

conda-forge-admin commented Aug 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

conda-forge-admin commented Aug 2, 2025

Uh oh!

HaoZeke commented Aug 2, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

HaoZeke commented Aug 2, 2025 •

edited

Loading

github-actions bot commented Aug 2, 2025 •

edited

Loading

HaoZeke commented Aug 2, 2025 •

edited

Loading

conda-forge-admin commented Aug 2, 2025 •

edited

Loading