Skip to content

Adding TARTS package a new Astronomy package #30745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

PetchMa
Copy link

@PetchMa PetchMa commented Aug 8, 2025

TARTS: a new package that is very early in development for astronomy wavefront aberration estimations

We are very early in the development but would like to publish the code to iterate with our community!

Also this is our first time contributing so if theres anything missing let us know!

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

github-actions bot commented Aug 8, 2025

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/tarts/meta.yaml) and found some lint.

Here's what I've got...

For recipes/tarts/meta.yaml:

  • ❌ The recipe could do with some maintainers listed in the extra/recipe-maintainers section.
  • ❌ The recipe must have some tests.
  • ❌ The recipe must have a build/number section.

For recipes/tarts/meta.yaml:

  • ℹ️ No valid build backend found for Python recipe for package tarts using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.
  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the host section of the recipe, you should usually use the pin python {{ python_min }} for the python entry.
    • For the run section of the recipe, you should usually use the pin python >={{ python_min }} for the python entry.
    • For the test.requires section of the recipe, you should usually use the pin python {{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/16822370749. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/tarts/meta.yaml) and found it was in an excellent condition.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/tarts/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/tarts/meta.yaml:

  • ℹ️ Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.
  • ℹ️ Recipes should usually depend on astropy-base as opposed to astropy. astropy-base only has the required dependancies whereas astropy now has all optional dependancies as well.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/16837507346. Examine the logs at this URL for more detail.

@PetchMa
Copy link
Author

PetchMa commented Aug 8, 2025

Hi @conda-forge/staged-recipes, this is my first contribution to conda-forge. this is ready for review — almost all checks are passing. Could someone please take a look? Thank you!

p.s I cannot seem to get the Windows Build to pass but all other tests have passed. Any additional comments would be appreciated!

Copy link
Contributor

github-actions bot commented Aug 8, 2025

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

@PetchMa
Copy link
Author

PetchMa commented Aug 8, 2025

@conda-forge-admin, please ping team

@PetchMa
Copy link
Author

PetchMa commented Aug 8, 2025

Asking for review from @conda-forge/help-python

@github-actions github-actions bot added the python label Aug 8, 2025
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/staged-recipes and so here I am doing that.

Copy link
Contributor

github-actions bot commented Aug 8, 2025

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

Copy link
Member

@synapticarbors synapticarbors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The windows failure might be solved if you remove the python_min as I suggested in another comment. I believe pytorch was never built for windows on python 3.8

@@ -0,0 +1,53 @@
{% set name = "tarts" %}
{% set version = "0.0.0a4" %} # Update this to your current version
{% set python_min = "3.8" %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We typically ask that python_min is not explicitly set unless it is greater than the current conda-forge global pin (currently 3.9).

- pandas
- gitpython

test:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Aug 11, 2025

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/tarts/meta.yaml, recipes/meta.yaml) and found some lint.

Here's what I've got...

For recipes/tarts/meta.yaml:

  • ❌ noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >={{ python_min }} in the run section of your recipe. You may also want to check the upstream source for the package's Python compatibility.

For recipes/tarts/meta.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the host section of the recipe, you should usually use the pin python {{ python_min }} for the python entry.
    • For the run section of the recipe, you should usually use the pin python >={{ python_min }} for the python entry.
    • For the test.requires section of the recipe, you should usually use the pin python {{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/16871030933. Examine the logs at this URL for more detail.

Copy link
Contributor

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/meta.yaml:
    • lints:
      • Please put your recipe in its own directory in the recipes/ directory as recipe/<name of feedstock>/<your recipe file>.yaml.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Aug 11, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/tarts/meta.yaml) and found it was in an excellent condition.

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@PetchMa
Copy link
Author

PetchMa commented Aug 11, 2025

The windows failure might be solved if you remove the python_min as I suggested in another comment. I believe pytorch was never built for windows on python 3.8

Hi @synapticarbors thanks for the feedback! I have since addressed your suggestions directly and now all checks have passed. Could I receive a second review for merge please?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants