-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Adding TARTS package a new Astronomy package #30745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/tarts/meta.yaml:
For recipes/tarts/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/16822370749. Examine the logs at this URL for more detail. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/tarts/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/16837507346. Examine the logs at this URL for more detail. |
Hi @conda-forge/staged-recipes, this is my first contribution to conda-forge. this is ready for review — almost all checks are passing. Could someone please take a look? Thank you! p.s I cannot seem to get the Windows Build to pass but all other tests have passed. Any additional comments would be appreciated! |
To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks! |
@conda-forge-admin, please ping team |
Asking for review from @conda-forge/help-python |
Hi! This is the friendly automated conda-forge-webservice. I was asked to ping @conda-forge/staged-recipes and so here I am doing that. |
To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The windows failure might be solved if you remove the python_min
as I suggested in another comment. I believe pytorch was never built for windows on python 3.8
recipes/tarts/meta.yaml
Outdated
@@ -0,0 +1,53 @@ | |||
{% set name = "tarts" %} | |||
{% set version = "0.0.0a4" %} # Update this to your current version | |||
{% set python_min = "3.8" %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We typically ask that python_min
is not explicitly set unless it is greater than the current conda-forge global pin (currently 3.9).
- pandas | ||
- gitpython | ||
|
||
test: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend adding a pip check
:
https://github.com/conda-forge/staged-recipes/blob/main/recipes/example/meta.yaml#L64-L67
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/tarts/meta.yaml:
For recipes/tarts/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/16871030933. Examine the logs at this URL for more detail. |
Hi! This is the staged-recipes linter and I found some lint. File-specific lints and/or hints:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
Hi @synapticarbors thanks for the feedback! I have since addressed your suggestions directly and now all checks have passed. Could I receive a second review for merge please? Thanks! |
TARTS: a new package that is very early in development for astronomy wavefront aberration estimations
We are very early in the development but would like to publish the code to iterate with our community!
Also this is our first time contributing so if theres anything missing let us know!
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).