Conversation
|
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge/help-c-cpp, ready for review! |
|
@conda-forge-admin, please ping conda-forge/help-c-cpp |
|
Hi! This is the friendly automated conda-forge-webservice. I was asked to ping @conda-forge/help-c-cpp and so here I am doing that. |
Add SSH key generation and start SSH daemon for macOS builds.
Updated CMake command for improved build process and removed unnecessary dependencies for Windows.
Refactor CMake commands to handle cross-compilation for macOS and Linux. Added USE_BOOST_ASIO option for Windows builds.
Remove version constraint for libboost-devel on osx or win.
Removed unnecessary sed command for Debug configuration in both unix and win sections.
Removed USE_BOOST_ASIO option from cmake commands in recipe.yaml.
Removed test compilation for macOS and Windows due to lack of test code.
Remove Debug configuration reference from CMakeLists.txt for Windows.
Removed backup files after sed commands and updated build commands to specify Release configuration.
Removed unnecessary configuration flags from build and test commands.
Updated run_exports format and added package_contents for tests.
Removed unnecessary SSH setup for OSX during build process.
|
@traversaro since you had the final look, would you also like to merge? |
|
Can you also make separate |
|
Ready to be merged. |
This pull request introduces a new recipe for the
libpinchlibrary, enabling its build and packaging for multiple platforms. The main changes include adding build scripts for Windows and Unix, applying patches to improve compatibility, and specifying package metadata and requirements.Build scripts and platform support:
build.shfor Unix platforms andbuild.batfor Windows, enabling automated build, test, and installation steps tailored to each environment. [1] [2]Packaging and metadata:
recipe.yamlspecifying package metadata, source location, build requirements, runtime dependencies, test configuration, and maintainer information.Patches for compatibility:
fix-include-target_sources.patchto correct the header file location inCMakeLists.txt, ensuring headers are properly installed.remove-include-factory-header.patchto remove unnecessarycryptopp/factory.hincludes, resolving compatibility issues with conda-forge's cryptopp package.Checklist
url) rather than a repo (e.g.git_url) is used in your recipe (see here for more details).