Skip to content

Comments

Add libpinch v1.2.1#31924

Open
eunos-1128 wants to merge 30 commits intoconda-forge:mainfrom
eunos-1128:libpinch
Open

Add libpinch v1.2.1#31924
eunos-1128 wants to merge 30 commits intoconda-forge:mainfrom
eunos-1128:libpinch

Conversation

@eunos-1128
Copy link
Contributor

@eunos-1128 eunos-1128 commented Jan 14, 2026

This pull request introduces a new recipe for the libpinch library, enabling its build and packaging for multiple platforms. The main changes include adding build scripts for Windows and Unix, applying patches to improve compatibility, and specifying package metadata and requirements.

Build scripts and platform support:

  • Added build.sh for Unix platforms and build.bat for Windows, enabling automated build, test, and installation steps tailored to each environment. [1] [2]

Packaging and metadata:

  • Created recipe.yaml specifying package metadata, source location, build requirements, runtime dependencies, test configuration, and maintainer information.

Patches for compatibility:

  • Added fix-include-target_sources.patch to correct the header file location in CMakeLists.txt, ensuring headers are properly installed.
  • Added remove-include-factory-header.patch to remove unnecessary cryptopp/factory.h includes, resolving compatibility issues with conda-forge's cryptopp package.

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@github-actions
Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/libpinch/recipe.yaml) and found it was in an excellent condition.

@eunos-1128
Copy link
Contributor Author

@conda-forge/help-c-cpp, ready for review!

@eunos-1128
Copy link
Contributor Author

@conda-forge-admin, please ping conda-forge/help-c-cpp

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/help-c-cpp and so here I am doing that.

Add SSH key generation and start SSH daemon for macOS builds.
Updated CMake command for improved build process and removed unnecessary dependencies for Windows.
Refactor CMake commands to handle cross-compilation for macOS and Linux. Added USE_BOOST_ASIO option for Windows builds.
Remove version constraint for libboost-devel on osx or win.
Removed unnecessary sed command for Debug configuration in both unix and win sections.
Removed USE_BOOST_ASIO option from cmake commands in recipe.yaml.
Removed test compilation for macOS and Windows due to lack of test code.
Remove Debug configuration reference from CMakeLists.txt for Windows.
Removed backup files after sed commands and updated build commands to specify Release configuration.
Removed unnecessary configuration flags from build and test commands.
@eunos-1128 eunos-1128 requested a review from wolfv February 17, 2026 09:42
Removed unnecessary SSH setup for OSX during build process.
@wolfv
Copy link
Member

wolfv commented Feb 19, 2026

@traversaro since you had the final look, would you also like to merge?

@danielnachun
Copy link
Contributor

Can you also make separate build.sh and build.bat scripts here? These scripts are long enough that they should be in their own files and will make the main recipe much easier to read.

@eunos-1128
Copy link
Contributor Author

Ready to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants