Skip to content

Comments

Add: init new recipe damn#32265

Merged
ocefpaf merged 18 commits intoconda-forge:mainfrom
ramez17khaled:damn
Feb 23, 2026
Merged

Add: init new recipe damn#32265
ocefpaf merged 18 commits intoconda-forge:mainfrom
ramez17khaled:damn

Conversation

@ramez17khaled
Copy link
Contributor

@ramez17khaled ramez17khaled commented Feb 20, 2026

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Feb 20, 2026

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/damn/meta.yaml) and found some lint.

Here's what I've got...

For recipes/damn/meta.yaml:

  • ❌ There are too few lines. There should be one empty line at the end of the file.

For recipes/damn/meta.yaml:

  • ℹ️ Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/22218546236. Examine the logs at this URL for more detail.

@github-actions
Copy link
Contributor

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/damn/meta.yaml:
    • lints:
      • The following maintainers have not yet confirmed that they are willing to be listed here: breakthewall, danilodurs. Please ask them to comment on this PR if they are.

@github-actions
Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/damn/meta.yaml) and found it was in an excellent condition.

@github-actions
Copy link
Contributor

Hi! This is the staged-recipes linter and I found some lint.

It looks like some changes were made outside the recipes/ directory. To ensure everything runs smoothly, please make sure that recipes are only added to the recipes/ directory and no other files are changed.

If these changes are intentional (and you aren't submitting a recipe), please add a maintenance label to the PR.

File-specific lints and/or hints:

  • recipes/example/meta.yaml:

    • lints:
      • Do not edit or delete example recipes in recipes/example/ or recipe/example-v1/.
  • recipes/example-v1/README.md:

    • lints:
      • Please put your recipe in its own directory in the recipes/ directory as recipe/<name of feedstock>/<your recipe file>.yaml.
  • recipes/example-v1/recipe.yaml:

    • lints:
      • Do not edit or delete example recipes in recipes/example/ or recipe/example-v1/.

@github-actions
Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@ramez17khaled
Copy link
Contributor Author

@conda-forge-admin, please ping team conda-forge/help-python

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/staged-recipes and so here I am doing that.

@github-actions
Copy link
Contributor

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

@ramez17khaled
Copy link
Contributor Author

@conda-forge/help-python , recipe ready to review !

build:
number: 0
noarch: python
skip: True
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are not building anything here. Why did you add this? Where are you seeing this? Are you using AI to generate the recipe?

Suggested change
skip: True

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use TensorFlow with GPU support, but it fails on Windows tests. I tried using the latest version, but it still fails. Therefore, I decided to skip the Windows build for now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That skips everything, not Windows.

It's okay if a noarch package fails on a specific platform due to a missing dependency. We prefer using noarch because it's faster to build, and the package will work as soon as the missing dependency becomes available on that platform.

Copy link
Member

@ocefpaf ocefpaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please answer the reviewer questions and address the code comments.

@ocefpaf ocefpaf merged commit ab34b1c into conda-forge:main Feb 23, 2026
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants