Fix SpecsAreNotPlugins error for wheel-based conda plugins#106
Open
Fix SpecsAreNotPlugins error for wheel-based conda plugins#106
SpecsAreNotPlugins error for wheel-based conda plugins#106Conversation
jezdez
changed the title
SpecsAreNotPlugins error for wheel-based conda plugins
jezdez
force-pushed
the
fix/wheel-plugin-detection
branch
2 times, most recently
from
9b0864e to
5f7620f
Compare
jezdez
force-pushed
the
fix/wheel-plugin-detection
branch
from
5f7620f to
abb5a8a
Compare
PackageInfo.from_record() relied on conda's deprecated info/files manifest to discover .dist-info directories. Packages built by rattler-build (e.g. numpy) don't ship info/files at all, and wheel packages extracted by conda-pypi have neither info/files nor info/paths.json. Read info/paths.json first (the canonical source per the conda package contents CEP), fall back to info/files for older packages, and scan the filesystem as a last resort for bare wheels. Fixes #105
jezdez
force-pushed
the
fix/wheel-plugin-detection
branch
from
abb5a8a to
3bb863b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PackageInfo.from_record()relied solely on conda's deprecatedinfo/filesmanifest to discover.dist-infodirectories. This fails for:info/filesorinfo/paths.json)numpy,rattler-build) which only shipinfo/paths.json, notinfo/filesinfo/paths.jsonfirst (the canonical source per the conda package contents CEP), falls back toinfo/filesfor older packages, and scans the filesystem as a last resort for bare wheels.Fixes #105
Related: conda/conda-pypi#268
Test plan
tests/test_package_info.py— 8 tests)conda self install conda-pypiusing a wheel-based channel