Update delete code to move the extracted pkgs instead of removing the 1 by 1#467
Open
goanpeca wants to merge 2 commits intoconda-incubator:mainfrom
Open
Update delete code to move the extracted pkgs instead of removing the 1 by 1#467goanpeca wants to merge 2 commits intoconda-incubator:mainfrom
goanpeca wants to merge 2 commits intoconda-incubator:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR speeds up the action’s post-run cleanup (notably on Windows) by avoiding slow recursive deletion of extracted conda packages, addressing the reported multi-minute/hour cleanup regressions.
Changes:
- Replace per-directory recursive deletion with a fast “stash via rename” approach for extracted packages (leaving
cache/and archive files intact). - Add/update explanatory comments and log messages around the new cleanup strategy.
- Regenerate the bundled
dist/delete/index.jsoutput to match the updated source.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/delete.ts |
Changes cleanup strategy from rm -rf/move-to-temp to renaming extracted package directories into a stash directory for speed. |
dist/delete/index.js |
Re-bundled compiled output corresponding to the updated delete logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
goanpeca
force-pushed
the
fix/win/slow-post-run
branch
from
cd877d4 to
deb5566
Compare
goanpeca
force-pushed
the
fix/win/slow-post-run
branch
from
eb9f1c3 to
c6181b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the slow run times of post-run on windows.
Fixes #277
Fixes #280
Fixes #380