Fix syntax expansion and add tests#470
Open
goanpeca wants to merge 1 commit intoconda-incubator:mainfrom
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses #286 by fixing how environment.yml dependencies are scanned/patched when python-version is provided, and adds unit + workflow regression coverage to prevent name=version=build specs from being corrupted during YAML roundtrips.
Changes:
- Fix python dependency detection by using a correct python MatchSpec regex and by treating YAML deps as primitive strings (
typeof === "string"). - Add Vitest unit tests covering python spec replacement/appending and preservation of
name=version=builddependency strings. - Add a workflow regression job plus a minimal example environment file to verify
python-versionoverrides a pinned python in an env file.
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/env/yaml.ts |
Fixes dependency type check during YAML patching (string vs object). |
src/constants.ts |
Corrects PYTHON_SPEC regex so python=..., python>..., etc. are detected. |
src/__tests__/yaml.test.ts |
Adds unit tests for python-version patching + preservation of name=version=build. |
etc/example-environment-python-pinned.yml |
Adds a minimal pinned-python env used by regression workflow. |
dist/setup/index.js |
Updates bundled output for setup with the source fixes. |
dist/delete/index.js |
Updates bundled output for delete with the updated constants. |
.github/workflows/example-3.yml |
Adds a regression job verifying python-version overrides env-file python pin. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
goanpeca
force-pushed
the
fix/name-version-build
branch
from
f1919c4 to
f6b25f5
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 7 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #286
Fixed string check instead of String, and fix the regex.
Also added tests and a regression workflow that checks the fix.