Add manylinux_2_34 to supported MANYLINUX_TAGS#900
Open
guenp wants to merge 5 commits intoconda:mainfrom
Open
Conversation
✅ Deploy Preview for conda-lock ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Update expected hashes in test_default_virtual_package_input_hash_stability and test_default_virtual_package_input_hash_stability_cuda_version to reflect the new glibc 2.34 default. Old glibc 2.28 hashes are preserved in backward compatibility checks.
Add _replace_glibc_version to backwards_compatible_content_hashes so that lockfiles generated with the old glibc 2.28 default are still recognized as valid after bumping to 2.34. Update HASHES_V2 in the v2-to-v3 upgrade test to match the new default.
Use cast(SubdirMetadata, ...) instead of type: ignore comment, and use model_copy(deep=True) consistent with rest of file.
Author
|
@maresb curious to hear your thoughts on this PR. thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_2_34toMANYLINUX_TAGSinpypi_solver.py__glibcfrom2.28to2.34indefault-virtual-packages.yamlfor all Linux subdirsFollow-up to #847, which added
_2_18.Motivation
pyqir 0.12.3 only publishes Linux wheels for
manylinux_2_34(x86_64) andmanylinux_2_38(aarch64). SinceMANYLINUX_TAGScurrently maxes out at_2_28, conda-lock's PyPI solver rejects these wheels:The
--virtual-package-specworkaround doesn't help because even if__glibcis set to2.34, the hardcoded tag list doesn't include_2_34.Discussion
I'm open to discussing a better long-term solution — e.g., dynamically generating valid manylinux tags from the glibc version rather than maintaining a hardcoded list. Happy to iterate on this.
Test plan
--virtual-package-specwith__glibc: "2.34"works end-to-end