refactor: make package record optional for source dependencies #1995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make rattler handle relative paths to pypi dependencies in the LockFile. This helps when checking in pixi.lock files that reference local python packages. Instead of ending up with a machine specific path in the lock file we have a relative path that should work for all developers. This is the rattler part of prefix-dev/pixi#4680 The PR consists of several changes: * Bump the LockFile version: The relative paths will break when somebody goes back to a pixi version not supporting this * Enable non-pep508_extensions in the pep508_rs? crate. This is needed for it to parse relative URLs in the lock file correctly *Add an API to pass in the base directory used -- needed by pep508_rs to parse a relative path. * Keep the raw input for (some) path and urls as read from the lock file around. pep508_rs does turn everything into absolute paths right away, we need to keep that info somewhere. Closes: conda#1977
hunger
force-pushed
the
feature/lockfile-v7
branch
2 times, most recently
from
5dc615d to
8c97847
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make the package record data optional for source records.