refactor: use when syntax instead of ; if
#2007
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baszalmstra
changed the title
when syntax instead of ; if
baszalmstra
force-pushed
the
refactor-conditional-if-syntax-to-when
branch
from
5524359 to
74a4f44
Compare
baszalmstra
force-pushed
the
refactor-conditional-if-syntax-to-when
branch
from
74a4f44 to
9df16cc
Compare
…tests__after_activation.snap.new
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors how we parse conditionals. The previous syntax was
foo; if bar, but in the CEP we landed onfoo[when="bar"]. This PR implements parsing of the new syntax.What is still missing is
not. The CEP lists this as a feature, but this is not implemented in rattler.