refactor(py)!: rename exceptions to follow Error suffix convention#2022
Draft
kajal-jotwani wants to merge 1 commit intoconda:mainfrom
Draft
refactor(py)!: rename exceptions to follow Error suffix convention#2022kajal-jotwani wants to merge 1 commit intoconda:mainfrom
kajal-jotwani wants to merge 1 commit intoconda:mainfrom
Conversation
baszalmstra
changed the title
baszalmstra
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves an inconsistency where several exceptions were exported as
*Errorin Python but appeared with an*Exceptionsuffix in tracebacks and documentation. This mismatch was causing confusion in the developer experienceChanges made:
*Exceptionto*Errorinerror.rslib.rsto use the new names*Errorsuffix in both namespace and tracebacksRelated Issue: #1959