Skip to content

Fix config parsing#90

Merged
maha-mstfa merged 6 commits intoconduitio-labs:mainfrom
derElektrobesen:lost-spec
Feb 7, 2025
Merged

Fix config parsing#90
maha-mstfa merged 6 commits intoconduitio-labs:mainfrom
derElektrobesen:lost-spec

Conversation

@derElektrobesen
Copy link
Contributor

@derElektrobesen derElektrobesen commented Feb 5, 2025

Description

MySQL connector config parsing lost after conduit-connector-sdk library upgrading from v0.12.0 to v0.13.0

Fixes # (issue)

Quick checks:

  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@maha-mstfa
Copy link
Contributor

Hi @derElektrobesen! thanks for the contribution
there are still some changes needed for the workflows to pass, please refer to this PR for an example of similar connector changes for Conduit 0.13, and let us know if you have any questions 😄

@derElektrobesen
Copy link
Contributor Author

Fixed

Review again please

@maha-mstfa
Copy link
Contributor

@derElektrobesen thanks!
please give it another quick look and resolve the conflicts, we can include this in the next MySQL release once it's done.

@derElektrobesen
Copy link
Contributor Author

Conflicts are resolved.
Also removed generated by paramgen files.

@alarbada
Copy link
Contributor

alarbada commented Feb 7, 2025

LGTM

@maha-mstfa maha-mstfa merged commit b0c294b into conduitio-labs:main Feb 7, 2025
3 checks passed
@maha-mstfa
Copy link
Contributor

@derElektrobesen thank you for your contribution!
can you please tell us more about your use case for this connector, and what destination connector you're using? we'd love to know more about Conduit use cases for our users.
feel free to also join our discord if you haven't already! We'd love to hear from you there, and reach out to the team :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants