Skip to content

Fix model type in Action #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
szepeviktor wants to merge 2 commits into from
Closed

Fix model type in Action #246

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bedee04
Fix model type in Action
szepeviktor Aug 26, 2025
7869458
Update Action.php
szepeviktor Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Actions/Action.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@
{
$field->setAttribute('form', $this->getKey());
$field->id($this->getKey().'-'.$field->getAttribute('id'));
$field->resolveErrorsUsing(fn (Request $request): MessageBag => $this->errors($request));

Check failure on line 139 in src/Actions/Action.php

View workflow job for this annotation

GitHub Actions / 3️⃣ Static Analysis 

Anonymous function should return Illuminate\Support\MessageBag but returns Illuminate\Contracts\Support\MessageBag.

if ($field instanceof Relation) {
$field->resolveRouteKeyNameUsing(fn (): string => Str::of($field->getRelationName())->singular()->ucfirst()->prepend($this->getKey())->value());
Expand Down Expand Up @@ -216,6 +216,7 @@

if (in_array(HasRootEvents::class, class_uses_recursive($model))) {
$models->each(static function (Model $model) use ($request): void {
assert($model instanceof HasRootEvents);

Check failure on line 219 in src/Actions/Action.php

View workflow job for this annotation

GitHub Actions / 3️⃣ Static Analysis 

Instanceof between Illuminate\Database\Eloquent\Model and trait Cone\Root\Traits\HasRootEvents will always evaluate to false.

Check failure on line 219 in src/Actions/Action.php

View workflow job for this annotation

GitHub Actions / 3️⃣ Static Analysis 

Instanceof between Illuminate\Database\Eloquent\Model and Cone\Root\Traits\HasRootEvents will always evaluate to false.

Check failure on line 219 in src/Actions/Action.php

View workflow job for this annotation

GitHub Actions / 3️⃣ Static Analysis 

Call to function assert() with false will always evaluate to false.
$model->recordRootEvent(
Str::of(static::class)->classBasename()->headline()->value(),
$request->user()
Expand Down
Loading