Fix RuntimeClass leaks when using Helm value overrides#53
Merged
fidencio merged 2 commits intoconfidential-containers:mainfrom Feb 5, 2026
Merged
Fix RuntimeClass leaks when using Helm value overrides#53fidencio merged 2 commits intoconfidential-containers:mainfrom
fidencio merged 2 commits intoconfidential-containers:mainfrom
Conversation
This reverts commit 5da715f. disableAll doesn't work correctly with Helm overrides. The option causes RuntimeClass leaks when using Helm value overrides due to deep merge behavior. Reverting to explicit shim disables. Related: confidential-containers#52 Signed-off-by: Beraldo Leal <bleal@redhat.com>
Without the disableAll, we need to disable them explicitly. Signed-off-by: Beraldo Leal <bleal@redhat.com>
fidencio
merged commit 06ae4b7
into
confidential-containers:main
169 of 174 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The kata-deploy's
disableAlloption doesn't work with Helm's deep merge: override files were getting shims from both parent and override instead of just the override.Example: kata-s390x.yaml created 8 RuntimeClasses instead of 4 (leaked x86_64 shims).
Disabling this, while we don't find a better approach.