td-shim: add a feature to support optional payload relocation#424
Draft
gaojiaqi7 wants to merge 1 commit intoconfidential-containers:mainfrom
Draft
td-shim: add a feature to support optional payload relocation#424gaojiaqi7 wants to merge 1 commit intoconfidential-containers:mainfrom
gaojiaqi7 wants to merge 1 commit intoconfidential-containers:mainfrom
Conversation
Signed-off-by: Jiaqi Gao <jiaqi.gao@intel.com>
Member
|
please describe what test has been done. |
jyao1
reviewed
Oct 19, 2022
| let image_base = coff_optional_region.pread::<u64>(0).ok()?; | ||
| let sections = Sections::parse(sections_buffer, num_sections as usize)?; | ||
| for section in sections { | ||
| if §ion.name == b".reloc\0\0" && image_base != new_image_base as u64 { |
Member
There was a problem hiding this comment.
if it is already relocated, why image_base != new_image_base?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #420
Signed-off-by: Jiaqi Gao jiaqi.gao@intel.com