Skip to content

INC-3834 Fix #3142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cqin-confluent wants to merge 4 commits into
base: main
Choose a base branch
from
Open

INC-3834 Fix #3142

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
72f73be
Update validateTopic logic to allow auth being handled
cqin-confluent Jul 31, 2025
80a2dbb
Nit
cqin-confluent Jul 31, 2025
1fe3123
Remove indentation
cqin-confluent Aug 7, 2025
12f3025
Merge branch 'main' of github.com:confluentinc/cli into INC-3834-fix
cqin-confluent Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions internal/kafka/command_topic.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,11 +118,8 @@ func (c *command) validateTopic(client *ckgo.AdminClient, topic string, cluster
}
}
if !foundTopic {
log.CliLogger.Trace("validateTopic failed due to topic not being found in the client's topic list")
return errors.NewErrorWithSuggestions(
fmt.Sprintf(errors.TopicDoesNotExistOrMissingPermissionsErrorMsg, topic),
fmt.Sprintf(errors.TopicDoesNotExistOrMissingPermissionsSuggestions, cluster.ID),
)
log.CliLogger.Tracef("validateTopic: Topic '%s' not visible in metadata, this could be due to ACL restrictions. Proceeding with operation to allow Kafka to handle authorization.", topic)
return nil
Copy link

Copilot AI Jul 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation is inconsistent with the surrounding code. The return statement has extra tabs that don't align with the rest of the function.

Suggested change
return nil
return nil

Copilot uses AI. Check for mistakes.
}

log.CliLogger.Tracef("validateTopic succeeded")
Expand Down
8 changes: 2 additions & 6 deletions internal/kafka/command_topic_onprem.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import (

ckgo "github.com/confluentinc/confluent-kafka-go/v2/kafka"

"github.com/confluentinc/cli/v4/pkg/errors"
"github.com/confluentinc/cli/v4/pkg/log"
)

Expand All @@ -26,11 +25,8 @@ func ValidateTopic(adminClient *ckgo.AdminClient, topic string) error {
}
}
if !foundTopic {
log.CliLogger.Tracef("validateTopic failed due to topic not being found in the client's topic list")
return errors.NewErrorWithSuggestions(
fmt.Sprintf(errors.TopicDoesNotExistOrMissingPermissionsErrorMsg, topic),
fmt.Sprintf(errors.TopicDoesNotExistOrMissingPermissionsSuggestions, "<cluster-id>"),
)
log.CliLogger.Tracef("validateTopic: Topic '%s' not visible in metadata, this could be due to ACL restrictions. Proceeding with operation to allow Kafka to handle authorization.", topic)
return nil
}

log.CliLogger.Tracef("validateTopic succeeded")
Expand Down
8 changes: 3 additions & 5 deletions pkg/errors/error_message.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,9 @@ const (
RequiredFlagNotSetErrorMsg = "required flag `--%s` not set"

// kafka cluster commands
CkuMoreThanZeroErrorMsg = "`--cku` value must be greater than 0"
TopicDoesNotExistOrMissingPermissionsErrorMsg = `topic "%s" does not exist or user does not have the ACLs or role bindings required to describe it`
TopicDoesNotExistOrMissingPermissionsSuggestions = "To list topics for Kafka cluster \"%[1]s\", use `confluent kafka topic list --cluster %[1]s`.\nTo list ACLs use `confluent kafka acl list --cluster %[1]s`.\nTo list role bindings use `confluent iam rbac role-binding list`."
KafkaClusterNotFoundErrorMsg = `Kafka cluster "%s" not found`
ChooseRightEnvironmentSuggestions = "Ensure the cluster ID you entered is valid.\n" +
CkuMoreThanZeroErrorMsg = "`--cku` value must be greater than 0"
KafkaClusterNotFoundErrorMsg = `Kafka cluster "%s" not found`
ChooseRightEnvironmentSuggestions = "Ensure the cluster ID you entered is valid.\n" +
"Ensure the cluster you are specifying belongs to the currently selected environment with `confluent kafka cluster list`, `confluent environment list`, and `confluent environment use`."
UnknownTopicErrorMsg = `unknown topic "%s"`
KafkaClusterMissingPrefixErrorMsg = `Kafka cluster "%s" is missing required prefix "lkc-"`
Expand Down