-
Notifications
You must be signed in to change notification settings - Fork 20
[MATRIX-1193] Add username/password option for elastic self hosted #3215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
b87b129 to
f8b5c45
Compare
|
4d06437 to
6189a17
Compare
|
lihaosky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!









Release Notes
New Features
confluent flink connection createandconfluent flink connection updatecommands. Users can now authenticate with Elastic using either--api-keyor--username/--passwordflags.Checklist
Whatsection below whether this PR applies to Confluent Cloud, Confluent Platform, or both.Test & Reviewsection below.Blast Radiussection below.What
This PR adds support for username/password (Basic Auth) as an alternative authentication method for Elastic connections in Confluent Cloud Flink.
Problem: Previously, Elastic connections only supported API key authentication. Some users prefer or require username/password authentication for their Elastic deployments.
Solution:
usernameandpasswordto the allowed secrets for theelasticconnection typeelasticto the username/password type mappings (alongsiderest,mcp_server, anda2a)--api-keyOR both--usernameand--password, but not both authentication methodsAUTH_TYPE: "BASIC"when username/password is used, orAUTH_TYPE: "API_KEY"when api-key is usedApplies to: Confluent Cloud only
Blast Radius
--api-keyare unaffected; the API key authentication path remains unchanged.References
Test & Review
CLI Integration Tests Added:
create-elastic-no-secret.golden- Tests error when no secrets provided for elasticcreate-elastic-mutually-exclusive-secret.golden- Tests error when both api-key and username are providedcreate-elastic-missing-required-secret.golden- Tests error when username provided without passwordManual Verification - Elastic CREATE connection with username/password:
Manual Verification - Elastic EDIT connection with username/password: