Skip to content

add argument null check for oauth params #2349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add argument null check for oauth params #2349

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52ab04e
add argument null check for oauth params
p3root Nov 16, 2024
c6d03b5
do not set second param, it will be set automatically by the implemen…
p3root Nov 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/Confluent.Kafka/ClientExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using System.Collections.Generic;
using System;
using System.Collections.Generic;

namespace Confluent.Kafka
{
Expand Down Expand Up @@ -41,6 +42,9 @@ public static class ClientExtensions
/// <seealso cref="OAuthBearerSetTokenFailure"/>
public static void OAuthBearerSetToken(this IClient client, string tokenValue, long lifetimeMs, string principalName, IDictionary<string, string> extensions = null)
{
ArgumentNullException.ThrowIfNull(tokenValue);
ArgumentNullException.ThrowIfNull(principalName);

client.Handle.LibrdkafkaHandle.OAuthBearerSetToken(tokenValue, lifetimeMs, principalName, extensions);
}

Expand Down