DGS-21595 Allow alternate KMS key IDs on a KEK #2508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for alternate KMS key IDs on a Key Encryption Key (KEK) to provide fallback options during encryption/decryption operations. The implementation creates a wrapper that tries multiple key IDs in sequence, allowing for better resilience when one key becomes unavailable.
Key changes:
- Introduces
KmsClientWrapperclass that handles multiple KMS key IDs with fallback logic - Adds configuration support for alternate KMS key IDs through properties or configs
- Updates the encryption executor to use the new wrapper instead of direct KMS client instantiation
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| KmsClientWrapper.cs | New wrapper class implementing fallback logic for multiple KMS key IDs |
| EncryptionExecutor.cs | Updated to use KmsClientWrapper and removed duplicate GetKmsClient method |
| SerializeDeserialize.cs | Added unit test for alternate KEK functionality |
airlock-confluentinc
bot
force-pushed
the
multiple-kek
branch
from
efa4304 to
eb23e0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Checklist
References
JIRA:
Test & Review
Open questions / Follow-ups