Skip to content

Allow LoadLibraryEx to search for librdkafka.dll using the default Windows search paths #2524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow LoadLibraryEx to search for librdkafka.dll using the default Windows search paths #2524

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/Confluent.Kafka/Impl/LibRdKafka.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,7 +615,9 @@ public static bool Initialize(string userSpecifiedPath)
#if NET462
private static void LoadNetFrameworkDelegates(string userSpecifiedPath)
{
string path = userSpecifiedPath;
var path = userSpecifiedPath;
var loadLibraryFlags = WindowsNative.LoadLibraryFlags.LOAD_WITH_ALTERED_SEARCH_PATH;

if (path == null)
{
// in net45, librdkafka.dll is not in the process directory, we have to load it manually
Expand Down Expand Up @@ -652,9 +654,17 @@ private static void LoadNetFrameworkDelegates(string userSpecifiedPath)
{
path = Path.Combine(baseDirectory, "librdkafka.dll");
}

if (!File.Exists(path))
{
// Allow LoadLibrary to search for the dll using the default Windows search path as defined here:
// https://learn.microsoft.com/en-us/windows/win32/dlls/dynamic-link-library-search-order#search-order-for-unpackaged-apps
path = "librdkafka.dll";
loadLibraryFlags = 0;
}
}

if (WindowsNative.LoadLibraryEx(path, IntPtr.Zero, WindowsNative.LoadLibraryFlags.LOAD_WITH_ALTERED_SEARCH_PATH) == IntPtr.Zero)
if (WindowsNative.LoadLibraryEx(path, IntPtr.Zero, loadLibraryFlags) == IntPtr.Zero)
{
// catch the last win32 error by default and keep the associated default message
var win32Exception = new Win32Exception();
Expand Down