Skip to content

make ErrMsgTimedOut count as timeout error #1422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

make ErrMsgTimedOut count as timeout error #1422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b088b71
make ErrMsgTimedOut count as timeout error
marcoferrer Apr 24, 2025
bd61136
Update error_test.go
marcoferrer Apr 24, 2025
a19b237
Merge branch 'master' into patch-1
marcoferrer May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion kafka/error.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ func (e Error) IsRetriable() bool {
// IsTimeout returns true if the error is a timeout error.
// A timeout error indicates that the operation timed out locally.
func (e Error) IsTimeout() bool {
return e.code == ErrTimedOut || e.code == ErrTimedOutQueue
return e.code == ErrTimedOut || e.code == ErrTimedOutQueue || e.code == ErrMsgTimedOut
}

// TxnRequiresAbort returns true if the error is an abortable transaction error
Expand Down
9 changes: 9 additions & 0 deletions kafka/error_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,15 @@ func TestFatalError(t *testing.T) {
t.Logf("%v", normalErr)
}

// TestIsTimeoutError tests timeout errors
func TestIsTimeoutError(t *testing.T) {
err := newErrorFromString(ErrMsgTimedOut, "Testing timeout error")
if !err.IsTimeout() {
t.Errorf("Expected IsTimeout() to return true for %v", err)
}
t.Logf("%v", err)
}

// TestFatalErrorClient tests fatal errors using a client instance
func TestFatalErrorClient(t *testing.T) {
p, err := NewProducer(&ConfigMap{})
Expand Down