-
Notifications
You must be signed in to change notification settings - Fork 20
fix: Apply timeout correctly to consumeNum #330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
andrewhessler
wants to merge
19
commits into
confluentinc:master
Choose a base branch
from
andrewhessler:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
9a13db3
apply timeout to batch
andrewhessler 7d6d811
allow 0 timeout in calc
andrewhessler adc6161
extract 1 into descriptive var
andrewhessler 452f9c5
add bool to worker consume num
andrewhessler 370b147
update kafka-consumer.js with bool
andrewhessler 5f4fa5f
update arg parsing in consume num path
andrewhessler 9b067c7
update headers
andrewhessler c43e99e
lint
andrewhessler 592ba1f
add tests
andrewhessler 2aa98ea
missed word
andrewhessler 5914c1f
clean up
andrewhessler 24c8cf3
last clean
andrewhessler 6664c16
fix args error
andrewhessler 8c88361
fix timeout
andrewhessler 6ef3c7c
fix timeout
andrewhessler a64dabb
final tests
andrewhessler 515b131
final tests
andrewhessler 060c26e
clean up newline
andrewhessler 2f0755b
comments
andrewhessler File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.